AUDIT-WP-0009 T04/T06/T07 — heartbeats, reconciliation, and a home for findings
The detection half audit-core argued up to a MUST and then could not support. Two registered sources were waiting on it. T04, heartbeats. A heartbeat is an ordinary event — same envelope, same append-only custody, same chain, no special table. Deliberate: a heartbeat stored outside the chain would be the one record here that could be back-dated. Declared per class rather than per source, because a per-source heartbeat from a mixed-volume emitter is satisfied by its chattiest class and says nothing about the quiet, security-relevant one, which is the only reason heartbeats exist. Not the §17 cadence schema T05 waits on: cadence describes expected rate, this says how often a source promises to say "nothing to report" for a class that may legitimately be silent. no_heartbeat_since_registration is its own finding kind rather than a skip — it is the case most likely to be a broken integration and the one a naive "compare against last seen" implementation silently drops. Grace widens the window so one late run does not flap; it never removes a finding. T06, reconciliation. Counts, never payloads. The awkward part is that every registered sender holds may_read: false, which taken literally makes the §9.6 reconciliation obligation undischargeable by every source actually registered. Resolved by observing that a source asking how many of its own events we hold is not reading the archive — it learns nothing it did not itself emit. So the surface is scoped to the caller's own sources and tenants and returns no payloads; anything wider stays behind may_read and full tenant scope. Another source's counts return 403 rather than an empty count, because a zero would read as "we hold none of yours" — a false answer to a question about completeness. No default window, since a count whose bounds the caller did not choose is not comparable to anything the caller computed. T07, the findings surface. /v1/stream-findings, following the dead-letter and secret-finding conventions: may_read plus full tenant scope, since findings span every sender and carry no tenant key to filter on. The bound is on every response rather than in a document nobody opens beside it. A missing heartbeat is not proof of suppression, and agreement on counts proves neither completeness nor that any event occurred. Both controls cover loss, outage, drain failure and accident; neither covers a source lying about itself, and where the emitter is compromised both agree with it. Closing that needs an observer independent of the emitter, which §16 put outside our scope. The scope overlay may shorten a heartbeat interval or add a class, never lengthen or remove one — same asymmetry as evidence_kind, and for the same reason: a ConfigMap refresh must not widen the window in which a suppressed class goes unnoticed without anyone deciding to. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nb7Q6ZmXppNDkTWytfYqfv Assistant: claude-code Assistant-Model: opus Assistant-Process: 2069992@bnt-lap001 Assistant-Session: 167dd7f8-2a25-4be1-aa46-3b6f1a5f94c6
This commit is contained in:
parent
de9e3abe5f
commit
b098fb12ca
7 changed files with 780 additions and 1 deletions
|
|
@ -46,7 +46,7 @@ from audit_core.redaction import (
|
|||
apply_policy,
|
||||
finding_from_path,
|
||||
)
|
||||
from audit_core.senders import SenderIdentity, SenderRegistry, development_registry
|
||||
from audit_core.senders import WILDCARD, SenderIdentity, SenderRegistry, development_registry
|
||||
from audit_core.sqlite_backend import SQLiteAuditBackend
|
||||
|
||||
MAX_BODY_BYTES = 256 * 1024
|
||||
|
|
@ -164,10 +164,21 @@ class IngestionApplication:
|
|||
"/v1/secret-findings",
|
||||
"/v1/stats",
|
||||
"/v1/integrity",
|
||||
"/v1/stream-findings",
|
||||
)
|
||||
):
|
||||
return self._read(start_response, environ, path, identity)
|
||||
|
||||
# Reconciliation is deliberately routed BEFORE the may_read gate.
|
||||
# A source asking how many of its own events audit-core holds is not
|
||||
# reading the archive — it learns nothing it did not itself emit — and
|
||||
# §9.6 makes that comparison the source's own detection obligation. A
|
||||
# writer with may_read: false must therefore be able to ask, or the
|
||||
# obligation audit-core argued for is undischargeable by every sender
|
||||
# actually registered. Cross-source counts stay behind may_read.
|
||||
if method == "GET" and path == "/v1/reconciliation":
|
||||
return self._reconciliation(start_response, environ, identity)
|
||||
|
||||
if path != "/v1/events" or method != "POST":
|
||||
return self._json(start_response, HTTPStatus.NOT_FOUND, {"error": "not_found"})
|
||||
|
||||
|
|
@ -264,6 +275,8 @@ class IngestionApplication:
|
|||
)
|
||||
if path == "/v1/stats":
|
||||
return self._json(start_response, HTTPStatus.OK, self.counters.snapshot())
|
||||
if path == "/v1/stream-findings":
|
||||
return self._stream_findings(start_response)
|
||||
if path == "/v1/secret-findings":
|
||||
return self._json(
|
||||
start_response, HTTPStatus.OK,
|
||||
|
|
@ -309,6 +322,97 @@ class IngestionApplication:
|
|||
start_response, HTTPStatus.SERVICE_UNAVAILABLE, {"error": "backend_unavailable"}
|
||||
)
|
||||
|
||||
def _reconciliation(self, start_response, environ, identity):
|
||||
"""Per-class counts of one source's own events (AUDIT-WP-0009-T06).
|
||||
|
||||
Counts, never payloads, and never another source's. The comparison a
|
||||
source makes against its own state transitions is the §9.6 detection
|
||||
obligation; audit-core supplies the numerator and says nothing about
|
||||
what the answer means.
|
||||
"""
|
||||
query = parse_qs(environ.get("QUERY_STRING", ""))
|
||||
source = (query.get("source") or [""])[0]
|
||||
if not source:
|
||||
return self._json(
|
||||
start_response, HTTPStatus.BAD_REQUEST, {"error": "source_required"}
|
||||
)
|
||||
if not identity.permits_source(source):
|
||||
# 403 rather than an empty count. A zero here would read as "we
|
||||
# hold none of yours", which is a materially different and false
|
||||
# answer to a question about completeness.
|
||||
return self._json(
|
||||
start_response, HTTPStatus.FORBIDDEN, {"error": "source_not_allowed"}
|
||||
)
|
||||
window = _window(query)
|
||||
if window is None:
|
||||
return self._json(
|
||||
start_response, HTTPStatus.BAD_REQUEST,
|
||||
{"error": "since_and_until_required"},
|
||||
)
|
||||
since, until = window
|
||||
tenant = (query.get("tenant") or [""])[0] or None
|
||||
if tenant is not None and not identity.permits_tenant(tenant):
|
||||
return self._json(
|
||||
start_response, HTTPStatus.FORBIDDEN, {"error": "tenant_not_allowed"}
|
||||
)
|
||||
if tenant is None and not identity.has_full_tenant_scope():
|
||||
# A scoped credential must name the tenant it is counting, so the
|
||||
# answer cannot silently aggregate across a boundary it may not see.
|
||||
return self._json(
|
||||
start_response, HTTPStatus.BAD_REQUEST, {"error": "tenant_required"}
|
||||
)
|
||||
counter = getattr(self.backend, "event_counts", None)
|
||||
if not callable(counter):
|
||||
return self._json(
|
||||
start_response, HTTPStatus.NOT_FOUND,
|
||||
{"error": "reconciliation_not_supported"},
|
||||
)
|
||||
try:
|
||||
counts = counter(source, since, until, tenant)
|
||||
except BackendUnavailableError as exc:
|
||||
log.error("reconciliation failed: %s", exc)
|
||||
return self._json(
|
||||
start_response, HTTPStatus.SERVICE_UNAVAILABLE,
|
||||
{"error": "backend_unavailable"},
|
||||
)
|
||||
return self._json(start_response, HTTPStatus.OK, {
|
||||
"source": source,
|
||||
"tenant": tenant,
|
||||
"since": since,
|
||||
"until": until,
|
||||
"counts": counts,
|
||||
# Said in the response because this is the number most likely to
|
||||
# be quoted out of context in someone else's conformance argument.
|
||||
"means": (
|
||||
"the count of events audit-core accepted and stored in this "
|
||||
"window. Divergence from the source's own count is a finding "
|
||||
"for the source; agreement proves neither completeness nor "
|
||||
"that any event occurred."
|
||||
),
|
||||
})
|
||||
|
||||
def _stream_findings(self, start_response):
|
||||
"""Missing-heartbeat findings (AUDIT-WP-0009-T04, T07)."""
|
||||
from audit_core.stream_findings import evaluate
|
||||
|
||||
reader = getattr(self.backend, "last_heartbeats", None)
|
||||
if not callable(reader):
|
||||
return self._json(
|
||||
start_response, HTTPStatus.NOT_FOUND,
|
||||
{"error": "stream_findings_not_supported"},
|
||||
)
|
||||
last: dict[tuple[str, str], str | None] = {}
|
||||
for identity in self.senders.identities:
|
||||
for source in identity.sources:
|
||||
if source == WILDCARD:
|
||||
continue
|
||||
for event_class, at in reader(source).items():
|
||||
last[(source, event_class)] = at
|
||||
findings = evaluate(self.senders.identities, last)
|
||||
return self._json(start_response, HTTPStatus.OK, {
|
||||
"stream_findings": [finding.as_dict() for finding in findings],
|
||||
})
|
||||
|
||||
def _count_secrets(self, payload: Any, identity, outcome: str, findings) -> None:
|
||||
"""Count secret-shaped fields by path, sender, source and action.
|
||||
|
||||
|
|
@ -472,9 +576,32 @@ _UNSCOPED_READ_PATHS = frozenset({
|
|||
"/v1/stats",
|
||||
"/v1/secret-findings",
|
||||
"/v1/integrity",
|
||||
# Findings span every registered sender and carry no tenant key, so there
|
||||
# is nothing to filter on. A scoped reader is refused rather than served
|
||||
# instance-wide facts — the same rule as the other three.
|
||||
"/v1/stream-findings",
|
||||
})
|
||||
|
||||
|
||||
def _window(query: dict[str, list[str]]) -> tuple[str, str] | None:
|
||||
"""Require an explicit bounded window for a reconciliation query.
|
||||
|
||||
No default window. A count whose bounds the caller did not choose is not
|
||||
comparable against anything the caller computed, and would be quoted as
|
||||
though it were.
|
||||
"""
|
||||
since = (query.get("since") or [""])[0]
|
||||
until = (query.get("until") or [""])[0]
|
||||
if not since or not until:
|
||||
return None
|
||||
try:
|
||||
start = _normalize_timestamp(since)
|
||||
end = _normalize_timestamp(until)
|
||||
except ValueError:
|
||||
return None
|
||||
return (start, end) if start < end else None
|
||||
|
||||
|
||||
def _readable_by(identity, record: dict) -> bool:
|
||||
"""Whether ``identity`` may read ``record``.
|
||||
|
||||
|
|
|
|||
|
|
@ -24,6 +24,7 @@ import time
|
|||
from datetime import datetime, timezone
|
||||
from typing import Any
|
||||
|
||||
from audit_core.stream_findings import HEARTBEAT_ACTION
|
||||
from audit_core.interface import (
|
||||
AcceptResult,
|
||||
AuditEvent,
|
||||
|
|
@ -408,6 +409,37 @@ class PostgresAuditBackend:
|
|||
)
|
||||
return [{"accepted_at": _iso(at), **rec} for rec, at in rows]
|
||||
|
||||
def event_counts(
|
||||
self, source: str, since: str, until: str, tenant: str | None = None
|
||||
) -> list[dict]:
|
||||
"""Per-class counts for one source over a bounded window.
|
||||
|
||||
AUDIT-WP-0009-T06. Counts only — never payloads. A reconciliation
|
||||
answer that carried records would turn a completeness check into a read
|
||||
surface, and a source does not gain the right to read the archive by
|
||||
emitting into it.
|
||||
"""
|
||||
sql = (
|
||||
f"SELECT action, count(*) FROM {self._events} "
|
||||
"WHERE source = %s AND accepted_at >= %s AND accepted_at < %s"
|
||||
)
|
||||
params: tuple = (source, since, until)
|
||||
if tenant is not None:
|
||||
sql += " AND tenant = %s"
|
||||
params += (tenant,)
|
||||
sql += " GROUP BY action ORDER BY action"
|
||||
return [{"class": action, "count": count} for action, count in self._query(sql, params)]
|
||||
|
||||
def last_heartbeats(self, source: str) -> dict[str, str]:
|
||||
"""Most recent heartbeat per class for one source."""
|
||||
rows = self._query(
|
||||
f"SELECT record->'details'->'data'->>'class' AS cls, max(accepted_at) "
|
||||
f"FROM {self._events} WHERE source = %s AND action = %s "
|
||||
"GROUP BY cls",
|
||||
(source, HEARTBEAT_ACTION),
|
||||
)
|
||||
return {cls: _iso(at) for cls, at in rows if cls}
|
||||
|
||||
def replay(self, event_id: str) -> AcceptResult:
|
||||
"""Re-submit a stored event through :meth:`accept`.
|
||||
|
||||
|
|
|
|||
|
|
@ -68,6 +68,20 @@ class SenderIdentity:
|
|||
# §9.6 requires the trade be declared where the trail is documented, so it
|
||||
# travels with the identity rather than living only in prose.
|
||||
completeness_trade: str | None = None
|
||||
# §9.6 heartbeat declaration (AUDIT-WP-0009-T04): event class -> the
|
||||
# longest gap, in seconds, that is not yet a finding.
|
||||
#
|
||||
# This is deliberately NOT the §17 emission-cadence schema that T05 waits
|
||||
# on. Cadence describes a stream's expected *rate* and belongs to Taxonomy;
|
||||
# this is a registration property saying how often a source promises to say
|
||||
# "nothing to report" for a class that may legitimately be silent. The two
|
||||
# are complementary and audit-core is not inventing a competing rate shape.
|
||||
#
|
||||
# Keyed per class, not per source, on purpose. A per-source heartbeat from
|
||||
# a mixed-volume emitter is satisfied by its chattiest class and says
|
||||
# nothing about the quiet, security-relevant one — which is the only case
|
||||
# heartbeats exist for.
|
||||
heartbeat_classes: tuple[tuple[str, int], ...] = ()
|
||||
|
||||
def __post_init__(self) -> None:
|
||||
if not self.name:
|
||||
|
|
@ -102,6 +116,17 @@ class SenderIdentity:
|
|||
"completeness_trade — §9.6 requires emission atomicity of it"
|
||||
)
|
||||
|
||||
for action, interval in self.heartbeat_classes:
|
||||
if not action or not str(action).strip():
|
||||
raise ValueError(
|
||||
f"sender {self.name!r}: a heartbeat class needs an event class"
|
||||
)
|
||||
if not isinstance(interval, int) or isinstance(interval, bool) or interval <= 0:
|
||||
raise ValueError(
|
||||
f"sender {self.name!r}: heartbeat interval for {action!r} must "
|
||||
f"be a positive number of seconds, got {interval!r}"
|
||||
)
|
||||
|
||||
@property
|
||||
def is_load_bearing(self) -> bool:
|
||||
return self.evidence_kind == EVIDENCE_LOAD_BEARING
|
||||
|
|
@ -118,6 +143,7 @@ class SenderIdentity:
|
|||
"evidence_kind": self.evidence_kind,
|
||||
"completeness_claimed": False,
|
||||
"completeness_trade": self.completeness_trade,
|
||||
"heartbeat_classes": dict(self.heartbeat_classes),
|
||||
"detection_surface": None,
|
||||
}
|
||||
|
||||
|
|
@ -288,6 +314,7 @@ def _apply_scope_overlay(
|
|||
if "completeness_trade" in extra
|
||||
else identity.completeness_trade
|
||||
),
|
||||
heartbeat_classes=_overlay_heartbeats(identity, extra),
|
||||
)
|
||||
)
|
||||
return merged
|
||||
|
|
@ -313,6 +340,36 @@ def _overlay_evidence_kind(identity: SenderIdentity, extra: dict[str, Any]) -> s
|
|||
return declared
|
||||
|
||||
|
||||
def _overlay_heartbeats(
|
||||
identity: SenderIdentity, extra: dict[str, Any]
|
||||
) -> tuple[tuple[str, int], ...]:
|
||||
"""The overlay may add a heartbeat class or shorten an interval, never
|
||||
lengthen or remove one.
|
||||
|
||||
Same asymmetry as ``evidence_kind`` and for the same reason: a ConfigMap
|
||||
refresh must not be able to widen the window in which a suppressed class
|
||||
goes unnoticed, or drop the obligation entirely, without anyone deciding
|
||||
to. Tightening detection is safe in the direction a mistake would take it.
|
||||
"""
|
||||
if "heartbeat_classes" not in extra:
|
||||
return identity.heartbeat_classes
|
||||
declared = dict(identity.heartbeat_classes)
|
||||
proposed = dict(_heartbeat_classes(extra["heartbeat_classes"]))
|
||||
for action, interval in declared.items():
|
||||
if action not in proposed:
|
||||
raise ValueError(
|
||||
f"sender {identity.name!r}: the scope overlay may not remove "
|
||||
f"heartbeat class {action!r}"
|
||||
)
|
||||
if proposed[action] > interval:
|
||||
raise ValueError(
|
||||
f"sender {identity.name!r}: the scope overlay may not lengthen "
|
||||
f"the heartbeat interval for {action!r} "
|
||||
f"({interval}s -> {proposed[action]}s)"
|
||||
)
|
||||
return tuple(sorted(proposed.items()))
|
||||
|
||||
|
||||
def _parse_identities(raw: str) -> list[SenderIdentity]:
|
||||
try:
|
||||
entries = json.loads(raw)
|
||||
|
|
@ -338,9 +395,18 @@ def _identity_from(entry: Any) -> SenderIdentity:
|
|||
expires_at=_parse_expiry(entry.get("expires_at")),
|
||||
evidence_kind=str(entry.get("evidence_kind", EVIDENCE_ATTRIBUTIVE)),
|
||||
completeness_trade=_clean_trade(entry.get("completeness_trade")),
|
||||
heartbeat_classes=_heartbeat_classes(entry.get("heartbeat_classes")),
|
||||
)
|
||||
|
||||
|
||||
def _heartbeat_classes(value: Any) -> tuple[tuple[str, int], ...]:
|
||||
if not value:
|
||||
return ()
|
||||
if not isinstance(value, dict):
|
||||
raise ValueError("heartbeat_classes must be an object of class -> seconds")
|
||||
return tuple(sorted((str(k), v) for k, v in value.items()))
|
||||
|
||||
|
||||
def _clean_trade(value: Any) -> str | None:
|
||||
if value in (None, ""):
|
||||
return None
|
||||
|
|
|
|||
|
|
@ -13,6 +13,7 @@ import sqlite3
|
|||
import threading
|
||||
from datetime import datetime, timezone
|
||||
|
||||
from audit_core.stream_findings import HEARTBEAT_ACTION
|
||||
from audit_core.interface import (
|
||||
AcceptResult,
|
||||
AuditEvent,
|
||||
|
|
@ -218,6 +219,40 @@ class SQLiteAuditBackend:
|
|||
)
|
||||
return [{"accepted_at": at, **json.loads(rec)} for rec, at in rows]
|
||||
|
||||
def event_counts(
|
||||
self, source: str, since: str, until: str, tenant: str | None = None
|
||||
) -> list[dict]:
|
||||
"""Per-class counts for one source over a bounded window.
|
||||
|
||||
AUDIT-WP-0009-T06. Counts only — never payloads. A reconciliation
|
||||
answer that carried records would turn a completeness check into a read
|
||||
surface, and a source does not gain the right to read the archive by
|
||||
emitting into it.
|
||||
"""
|
||||
sql = (
|
||||
"SELECT json_extract(record, '$.action') AS action, count(*) "
|
||||
"FROM events WHERE json_extract(record, '$.source') = ? "
|
||||
"AND accepted_at >= ? AND accepted_at < ?"
|
||||
)
|
||||
params: tuple = (source, since, until)
|
||||
if tenant is not None:
|
||||
sql += " AND tenant = ?"
|
||||
params += (tenant,)
|
||||
sql += " GROUP BY action ORDER BY action"
|
||||
return [{"class": action, "count": count} for action, count in self._query(sql, params)]
|
||||
|
||||
def last_heartbeats(self, source: str) -> dict[str, str]:
|
||||
"""Most recent heartbeat per class for one source."""
|
||||
rows = self._query(
|
||||
"SELECT json_extract(record, '$.details.data.class') AS cls, "
|
||||
"max(accepted_at) FROM events "
|
||||
"WHERE json_extract(record, '$.source') = ? "
|
||||
"AND json_extract(record, '$.action') = ? "
|
||||
"GROUP BY cls",
|
||||
(source, HEARTBEAT_ACTION),
|
||||
)
|
||||
return {cls: at for cls, at in rows if cls}
|
||||
|
||||
def record_rejection(
|
||||
self,
|
||||
*,
|
||||
|
|
|
|||
131
audit_core/stream_findings.py
Normal file
131
audit_core/stream_findings.py
Normal file
|
|
@ -0,0 +1,131 @@
|
|||
"""Stream-completeness findings: when the trail itself is the defect.
|
||||
|
||||
`AUDIT-WP-0009-T04` and `T07`. `INTENT.md` principle 10 already says a degraded
|
||||
audit stream is itself an audit and operations event. The principle was in
|
||||
place; the mechanism was not.
|
||||
|
||||
**What this can and cannot see.** The hash chain proves records held were not
|
||||
altered or truncated. It says nothing about a record that never arrived, and
|
||||
§9.6 is explicit that omission is the acute risk for exactly the rare negative
|
||||
classes — revocation, denial, containment — where suppression is most valuable
|
||||
and least visible. Rate monitoring cannot help there either: a class that is
|
||||
legitimately silent for a month is indistinguishable from one being suppressed.
|
||||
|
||||
A heartbeat fixes that by inverting the burden. Instead of inferring health
|
||||
from events that may never come, the source makes a positive claim —
|
||||
*nothing to report for this class* — on a declared interval. The claim can
|
||||
itself go missing, and a missing claim is a finding. That is the whole idea,
|
||||
and it is the only control here that covers adversarial omission.
|
||||
|
||||
**The bound, stated because a finding surface invites over-reading.** A
|
||||
compromised source emits a truthful-looking heartbeat while suppressing the
|
||||
event it is supposed to be vouching for. Heartbeats cover loss, outage, drain
|
||||
failure and accident — most of what actually goes wrong — and do not cover a
|
||||
source lying about itself. Nothing an archive holds can close that; it needs an
|
||||
observer independent of the emitter.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from dataclasses import dataclass
|
||||
from datetime import datetime, timedelta, timezone
|
||||
from typing import Any, Iterable
|
||||
|
||||
# The event class a source uses to say "nothing to report". A heartbeat is an
|
||||
# ordinary event: same envelope, same append-only custody, same chain. It gets
|
||||
# no special table, because a heartbeat that lived outside the chain would be
|
||||
# the one record in this store that could be back-dated.
|
||||
HEARTBEAT_ACTION = "audit-core.heartbeat"
|
||||
|
||||
MISSING_HEARTBEAT = "missing_heartbeat"
|
||||
NEVER_HEARTBEAT = "no_heartbeat_since_registration"
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class StreamFinding:
|
||||
"""One reason to believe a stream is not telling the whole truth."""
|
||||
|
||||
kind: str
|
||||
sender: str
|
||||
source: str
|
||||
event_class: str
|
||||
expected_within_seconds: int
|
||||
last_seen: str | None
|
||||
overdue_seconds: int
|
||||
|
||||
def as_dict(self) -> dict[str, Any]:
|
||||
return {
|
||||
"kind": self.kind,
|
||||
"sender": self.sender,
|
||||
"source": self.source,
|
||||
"class": self.event_class,
|
||||
"expected_within_seconds": self.expected_within_seconds,
|
||||
"last_seen": self.last_seen,
|
||||
"overdue_seconds": self.overdue_seconds,
|
||||
# Said on every finding rather than in a document nobody opens
|
||||
# alongside it: this is the absence of a positive claim, not proof
|
||||
# that an event was suppressed.
|
||||
"means": (
|
||||
"a declared heartbeat did not arrive; the class may be healthy "
|
||||
"and the emitter silent. Absence is not proof of suppression."
|
||||
),
|
||||
}
|
||||
|
||||
|
||||
def _parse(value: str | None) -> datetime | None:
|
||||
if not value:
|
||||
return None
|
||||
try:
|
||||
parsed = datetime.fromisoformat(str(value).replace("Z", "+00:00"))
|
||||
except ValueError:
|
||||
return None
|
||||
return parsed if parsed.tzinfo else parsed.replace(tzinfo=timezone.utc)
|
||||
|
||||
|
||||
def evaluate(
|
||||
identities: Iterable[Any],
|
||||
last_heartbeats: dict[tuple[str, str], str | None],
|
||||
*,
|
||||
now: datetime | None = None,
|
||||
grace_factor: float = 1.5,
|
||||
) -> list[StreamFinding]:
|
||||
"""Findings for every declared heartbeat class that is overdue.
|
||||
|
||||
``last_heartbeats`` is keyed ``(source, class)``. A class with no heartbeat
|
||||
ever recorded produces a finding of its own kind rather than being skipped:
|
||||
a source that declared a heartbeat and never sent one is the case most
|
||||
likely to be a broken integration, and it is precisely the one a
|
||||
"compare against last seen" implementation silently drops.
|
||||
|
||||
``grace_factor`` exists so one late run does not flap a finding on and off,
|
||||
matching the reasoning behind the attestation freshness window. It widens
|
||||
the window; it never removes the finding.
|
||||
"""
|
||||
now = now or datetime.now(timezone.utc)
|
||||
findings: list[StreamFinding] = []
|
||||
for identity in identities:
|
||||
for event_class, interval in getattr(identity, "heartbeat_classes", ()):
|
||||
for source in sorted(identity.sources):
|
||||
if source == "*":
|
||||
# A wildcard source cannot be held to a heartbeat: there is
|
||||
# no determinate set of streams to expect one from. Refused
|
||||
# rather than guessed at.
|
||||
continue
|
||||
deadline = timedelta(seconds=interval * grace_factor)
|
||||
last = _parse(last_heartbeats.get((source, event_class)))
|
||||
if last is None:
|
||||
findings.append(StreamFinding(
|
||||
kind=NEVER_HEARTBEAT, sender=identity.name, source=source,
|
||||
event_class=event_class, expected_within_seconds=interval,
|
||||
last_seen=None, overdue_seconds=-1,
|
||||
))
|
||||
continue
|
||||
overdue = (now - last) - deadline
|
||||
if overdue.total_seconds() > 0:
|
||||
findings.append(StreamFinding(
|
||||
kind=MISSING_HEARTBEAT, sender=identity.name, source=source,
|
||||
event_class=event_class, expected_within_seconds=interval,
|
||||
last_seen=last.isoformat(),
|
||||
overdue_seconds=int(overdue.total_seconds()),
|
||||
))
|
||||
return findings
|
||||
Loading…
Add table
Add a link
Reference in a new issue