citation-evidence/src/app/App.tsx

137 lines
3.6 KiB
TypeScript
Raw Normal View History

Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
/**
* App the citation-evidence MVP shell.
*
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
* Composes the two top-level layouts:
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
*
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
* - Review mode (CE-WP-0002): collection list / viewer / evidence sidebar.
* - Forms mode (CE-WP-0003): form renderer / viewer / evidence strip,
* with click-to-link interaction.
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
*
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
* Mode selection is driven by `location.hash`: `#/forms/demo` lands in
* Forms mode; anything else (including empty) lands in Review mode. The
* top bar toggles between them. We keep the hash sync so reload + deep
* links work; T08's E2E asserts the `/forms/demo` navigation path.
*
* Engine and binder providers are both mounted at the App root so
* evidence/annotations/links survive switching tabs.
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
*/
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
import { useEffect, useState } from "react";
import { BinderProvider } from "@binder/index";
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
import {
EngineProvider,
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
useEngine,
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
} from "@work/index";
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
import { FormsApp } from "./forms/FormsApp";
import { ReviewLayout } from "./ReviewLayout";
type Mode = "review" | "forms";
const FORMS_HASH = "#/forms/demo";
function readModeFromHash(): Mode {
if (typeof window === "undefined") return "review";
return window.location.hash === FORMS_HASH ? "forms" : "review";
}
function writeModeToHash(mode: Mode) {
if (typeof window === "undefined") return;
const target = mode === "forms" ? FORMS_HASH : "";
if (window.location.hash !== target) {
if (target) {
window.location.hash = target;
} else {
// Clear hash without leaving "#" trailing in the URL bar.
history.replaceState(null, "", window.location.pathname + window.location.search);
}
}
}
function ModeRouter() {
const [mode, setMode] = useState<Mode>(() => readModeFromHash());
useEffect(() => {
function onHash() {
setMode(readModeFromHash());
}
window.addEventListener("hashchange", onHash);
return () => window.removeEventListener("hashchange", onHash);
}, []);
const handleModeChange = (next: Mode) => {
writeModeToHash(next);
setMode(next);
};
return (
<div style={{ display: "flex", flexDirection: "column", height: "100vh", color: "#222" }}>
<TopBar mode={mode} onModeChange={handleModeChange} />
<div style={{ flex: 1, minHeight: 0 }}>
{mode === "review" ? <ReviewLayout /> : <FormsApp />}
</div>
</div>
);
}
function TopBar({ mode, onModeChange }: { mode: Mode; onModeChange: (m: Mode) => void }) {
return (
<header
style={{
display: "flex",
gap: 8,
padding: "6px 12px",
borderBottom: "1px solid #ddd",
background: "#fafafa",
fontFamily: "system-ui, sans-serif",
alignItems: "center",
}}
>
<strong style={{ fontSize: 13, marginRight: 8 }}>citation-evidence</strong>
<button
onClick={() => onModeChange("review")}
aria-pressed={mode === "review"}
style={tabStyle(mode === "review")}
>
Review
</button>
<button
onClick={() => onModeChange("forms")}
aria-pressed={mode === "forms"}
style={tabStyle(mode === "forms")}
>
Forms
</button>
</header>
);
}
function tabStyle(active: boolean) {
return {
padding: "4px 12px",
fontSize: 12,
border: "1px solid #ccc",
borderBottom: active ? "2px solid #0050b3" : "1px solid #ccc",
background: active ? "#e8f0ff" : "white",
cursor: "pointer" as const,
};
}
function AppInner() {
const engine = useEngine();
return (
<BinderProvider bus={engine.bus}>
<ModeRouter />
</BinderProvider>
);
}
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
export function App() {
return (
<EngineProvider>
Implement CE-WP-0003 T01-T08: form binding + visual guide overlay T01 EvidenceLink/EvidenceSet types - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId - enum-conformance test parses SharedContracts.md and asserts the runtime lists match exactly T02 Binding service + in-memory link repo + active-state machine - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository - src/binder/services/bindings.ts: link/unlink/list/update/setActive emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated / EvidenceItemActivated - src/binder/state/active.ts: (target, evidence, annotation) reducer + ActiveStateProvider + useActiveState hook - extended engine/events/types.ts with EvidenceLinkCreated, EvidenceLinkUpdated, FormFieldActivated payloads T03 Rect registry (SharedContracts §7 — contract FROZEN) - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe + invalidate + getVersion for useSyncExternalStore - events.ts: scroll/resize/focus pumps via window + ResizeObserver + IntersectionObserver, rAF-throttled - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref), useRectRegistryVersion T04 Form schema + renderer - src/app/forms/demo-schema.ts: text/textarea/date minimal schema - src/binder/FormRenderer.tsx: renders schema, each field registers as rect kind="field"; active field gets aria-current="true" - placed in binder/ (not work/) because work cannot import binder per DependencyMap.md §2 and the renderer needs the rect-registry hook; workplan T04 was amended in-place to document this T05 Side-by-side Forms layout + click-to-link - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with hash route #/forms/demo - BinderProvider mounted at app root so links survive tab switching - stage-evidence-then-click-field linking interaction with banner + per-field link-count chip T06 Active-evidence cycling - src/app/forms/ActiveEvidenceChips.tsx: chips per active target, Tab cycles natively, first chip auto-activates on field focus, each chip registers as rect kind="evidence-card" - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll - EvidenceSidebar + EvidenceStrip highlight the active item via the new useLastActivatedEvidence hook in work/EngineContext T07 SVG visual-guide overlay - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG, draws field→card and card→highlight bezier curves for the active triple, rAF-throttled via the registry - src/anchor exposes getHighlightClientRects(annotationId); the spike viewer wraps highlights in [data-highlight-id] so the helper can locate them - src/app/forms/HighlightRectBridge.tsx: registers the active annotation's rect via that helper T08 End-to-end test (PRD scenario steps 5-9) - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from Review-mode capture through Forms-mode link to active triple + aria-current assertions + 2 SVG paths in the overlay - additional integration coverage: forms-link-flow + forms-active-cycling Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00
<AppInner />
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e Completes the PDF review slice end-to-end. After this commit a user can open a fixture, select text, save an evidence item with commentary, see it in the sidebar, reload the page, click the item, and the viewer scrolls to the passage. - T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests - SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe) - PDF.js text extract; per-page normalize then join with "\n\n" - PageMap + OffsetMap (gap-free coverage); pageLength = end - start - Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly - T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests - createSelectors emits the maximal redundant set (TextQuote + TextPosition + PdfRect + PdfPageText when available) - resolveSelectors implements the SharedContracts §7 ladder; confidence 1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved) - Cross-module integration test moved to tests/integration/ to honor the anchor↛source boundary lint rule - T05 engine: sync event bus over the closed §4 vocabulary, Map-backed repos, services, createEngine() composition root, 12 tests - T06 work + app: three-pane shell (CollectionList | ViewerShell | EvidenceSidebar) wired through EngineProvider; EngineContext lives in src/work/ to respect the work↛app boundary; SpikeApp deleted - T07 AnnotationToolbar: pendingSelection in context; Save runs createSelectors → engine.annotations.create → engine.evidence.create - T08 click-to-reopen + localStorage persistence - scrollToAnnotation state in context with a version counter so a second click on the same item re-fires the viewer scroll - captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage; restore bypasses services to avoid event-loops - active-document id persisted alongside the snapshot so reload lands on the same fixture; ADR-0005 written - 9 persistence tests - T09 tests/integration/app-prd-scenario.dom.test.tsx - end-to-end happy-dom test of PRD scenario steps 1-8 through the real React tree; viewer + ingest mocked per ADR-0004's headless-Chromium limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where useEngineEventTick values were not included in the useMemo deps, leaving stale memoization across event-driven re-renders - vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files - noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 10:58:11 +02:00
</EngineProvider>
);
}