41 rules classified executable / checkable / decorative, each tagged with
the failure class it catches. Counts: 11 executable, 22 checkable, 4
decorative (one of them dead policy).
Audit: history/260731-inner-loop-rule-audit.md
New tools/loop-lint.py makes 7 rules executable (tier declared, chaos
roll recorded, tier-L review trail, unmeasured-in-evidence, whole-file
loadability, reporting tools expose --self-test). It found three real
violations on its first run, none previously visible:
- specs/ArchitectureBlueprint.md was 543 lines against a ~400 limit
the loop has stated since v0.2 and never measured. Split at its own
section boundaries into Blueprint (1-8) + Runtime (9-15).
- tools/dep-weight.py and tools/rule-coverage.py had positive-control
logic and no --self-test, so nothing verified the control worked.
Adding rule-coverage's self-test exposed a latent instance of the exact
class this workplan is about: if the spec regex stopped matching, rules
was empty, missing was empty, and the tool exited 0 reporting "0/0" --
a silent pass, in the tool that reports our headline AM-1 number. Both
tools now assert they found something before reporting.
Two demotions applied in the spec rather than left implicit: "structured
over prose" is marked guidance (nothing can check it), and the 8k/10k
token budget is struck through and marked DEAD POLICY pointing at T05.
The audit's uncomfortable finding: rule 13 (re-derive inherited numbers)
has no mechanical form, is deliberately left decorative, and caught the
LARGEST error in CB-WP-0002. That is a counter-example to this
workplan's own hypothesis. "A rule that cannot be executed is not a
rule" is wrong as stated; the defensible version is that such a rule
cannot be relied on to fire, so it must not be the only defence for a
class that matters.
Class coverage: harness-does-nothing has five executable rules;
trusted-arithmetic has ZERO and produced the largest single error.
make loop-lint and make self-tests wired into `make all` and CI.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
202 lines
6.9 KiB
Python
Executable file
202 lines
6.9 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
"""AM-4: third-party dependency weight, measured as source under audit.
|
|
|
|
Crate count is a poor cross-ecosystem proxy — Rust splits crates far more
|
|
finely than npm, so "33 crates vs 120 npm packages" flatters us in one
|
|
direction and a low crate-count target punishes us in the other. What the
|
|
count stands in for is how much third-party source a reviewer would have
|
|
to audit. This measures that directly, in two configurations:
|
|
|
|
shipped-runtime cargo build --no-default-features (what a game ships)
|
|
dev-toolchain cargo build (adds scenario YAML)
|
|
|
|
Positive control (InnerLoop v1.0 §Step 5): every crate in the dependency
|
|
graph must be located on disk and produce a non-zero line count. A crate
|
|
that cannot be found is reported and the run exits non-zero rather than
|
|
silently under-reporting the total — under-reporting is the exact
|
|
direction this metric could be gamed.
|
|
|
|
Usage: python3 tools/dep-weight.py [--json] [--self-test]
|
|
"""
|
|
|
|
import glob
|
|
import json
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
|
|
PACKAGE = "games-ground"
|
|
CONFIGS = {
|
|
"shipped-runtime": ["--no-default-features"],
|
|
"dev-toolchain": [],
|
|
}
|
|
|
|
# AM-4a / AM-4b targets from specs/GameKernel.md §4. Breaching one fails
|
|
# the build: a gate that only reports is a suggestion.
|
|
TARGETS = {
|
|
"shipped-runtime": 250_000,
|
|
"dev-toolchain": 350_000,
|
|
}
|
|
|
|
|
|
def crates(extra_args):
|
|
"""Third-party crates in the normal (non-dev) dependency graph."""
|
|
if not shutil.which("cargo"):
|
|
print(
|
|
"ERROR: cargo not on PATH. Try: export PATH=\"$HOME/.cargo/bin:$PATH\"",
|
|
file=sys.stderr,
|
|
)
|
|
sys.exit(1)
|
|
out = subprocess.run(
|
|
["cargo", "tree", "-p", PACKAGE, "--edges", "normal", "--prefix", "none"]
|
|
+ extra_args,
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
).stdout
|
|
found = {}
|
|
for line in out.splitlines():
|
|
parts = line.split()
|
|
if len(parts) < 2 or not parts[1].startswith("v"):
|
|
continue
|
|
name, version = parts[0], parts[1].lstrip("v")
|
|
# Path dependencies are our own code, not third-party.
|
|
if "(/" in line:
|
|
continue
|
|
found[name] = version
|
|
return found
|
|
|
|
|
|
def source_lines(name, version):
|
|
"""Lines of Rust in the vendored source for one crate."""
|
|
roots = glob.glob(os.path.expanduser("~/.cargo/registry/src/*/"))
|
|
for root in roots:
|
|
# Version may carry a build suffix (e.g. 0.9.34+deprecated).
|
|
for d in glob.glob(f"{root}{name}-{version}*/") + glob.glob(f"{root}{name}-*/"):
|
|
total = 0
|
|
for dirpath, _, files in os.walk(d):
|
|
for f in files:
|
|
if f.endswith(".rs"):
|
|
try:
|
|
with open(os.path.join(dirpath, f), "rb") as fh:
|
|
total += fh.read().count(b"\n")
|
|
except OSError:
|
|
pass
|
|
if total:
|
|
return total
|
|
return 0
|
|
|
|
|
|
def self_test():
|
|
"""Each assertion pins a failure this tool must detect.
|
|
|
|
The controls that matter here are: an unlocatable crate must not be
|
|
silently counted as zero lines (that under-reports, the direction this
|
|
metric could be gamed), and a target breach must fail rather than
|
|
merely print.
|
|
"""
|
|
results = []
|
|
|
|
def check(name, ok, detail=""):
|
|
results.append((name, ok, detail))
|
|
|
|
# A crate that does not exist must measure zero, so the caller's
|
|
# `lines == 0` guard fires rather than silently shrinking the total.
|
|
check("unlocatable crate measures zero (so the guard fires)",
|
|
source_lines("definitely-not-a-real-crate-xyz", "9.9.9") == 0)
|
|
|
|
# A crate we do depend on must measure non-zero, or the guard above
|
|
# would fire on everything and the tool would never report at all.
|
|
real = source_lines("serde", "1")
|
|
check("a real vendored crate measures non-zero", real > 0,
|
|
f"{real:,} lines")
|
|
|
|
# Targets must be present and numeric — a missing target would make
|
|
# the breach check vacuous.
|
|
check("targets defined for every configuration",
|
|
set(TARGETS) == set(CONFIGS) and all(
|
|
isinstance(v, int) and v > 0 for v in TARGETS.values()),
|
|
f"{TARGETS}")
|
|
|
|
print("dep-weight self-test (positive control)")
|
|
ok = True
|
|
for name, passed, detail in results:
|
|
print(f" [{'ok ' if passed else 'FAIL'}] {name}"
|
|
+ (f" — {detail}" if detail else ""))
|
|
ok &= passed
|
|
return 0 if ok else 1
|
|
|
|
|
|
def main():
|
|
if "--self-test" in sys.argv:
|
|
return self_test()
|
|
|
|
report = {}
|
|
missing = []
|
|
for label, args in CONFIGS.items():
|
|
found = crates(args)
|
|
per_crate = {}
|
|
for name, version in sorted(found.items()):
|
|
lines = source_lines(name, version)
|
|
if lines == 0:
|
|
missing.append(f"{name} {version} ({label})")
|
|
per_crate[name] = lines
|
|
report[label] = {
|
|
"crates": len(found),
|
|
"third_party_loc": sum(per_crate.values()),
|
|
"per_crate": per_crate,
|
|
}
|
|
|
|
own = 0
|
|
for base in ("crates", "games", "tools"):
|
|
for dirpath, _, files in os.walk(base):
|
|
if "target" in dirpath.split(os.sep):
|
|
continue
|
|
for f in files:
|
|
if f.endswith(".rs"):
|
|
with open(os.path.join(dirpath, f), "rb") as fh:
|
|
own += fh.read().count(b"\n")
|
|
report["own_loc"] = own
|
|
|
|
if "--json" in sys.argv:
|
|
print(json.dumps(report, indent=2))
|
|
else:
|
|
print("AM-4 dependency weight")
|
|
print(f" own source {own:>9,} lines")
|
|
for label in CONFIGS:
|
|
r = report[label]
|
|
limit = TARGETS[label]
|
|
mark = "ok " if r["third_party_loc"] <= limit else "FAIL"
|
|
print(
|
|
f" {label:<18}{r['crates']:>3} crates "
|
|
f"{r['third_party_loc']:>9,} lines third-party "
|
|
f"[{mark} target {limit:,}]"
|
|
)
|
|
delta = (
|
|
report["dev-toolchain"]["third_party_loc"]
|
|
- report["shipped-runtime"]["third_party_loc"]
|
|
)
|
|
print(f" scenario tooling costs {delta:>9,} lines (dev only)")
|
|
|
|
if missing:
|
|
# Positive control: a crate we could not measure would silently
|
|
# shrink the total, so refuse to report rather than under-report.
|
|
print("\nERROR — source not found for:", ", ".join(missing), file=sys.stderr)
|
|
return 1
|
|
|
|
breached = [
|
|
(label, report[label]["third_party_loc"], limit)
|
|
for label, limit in TARGETS.items()
|
|
if report[label]["third_party_loc"] > limit
|
|
]
|
|
for label, actual, limit in breached:
|
|
print(
|
|
f"\nFAIL AM-4 — {label}: {actual:,} lines exceeds target {limit:,}",
|
|
file=sys.stderr,
|
|
)
|
|
return 1 if breached else 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|