Add schemaguard; correct check_request subject.type against shipped reality
approval-engine suggested a conformance check after the examples-contradict- prose class hit a third repository -- theirs. Fifteen lines, they said, and it would have caught our caring fixture and our provenance omission. Worth stealing, so we stole it. internal/schemaguard validates published examples against published schemas. It implements only the JSON Schema subset these schemas use, and the property that makes it trustworthy is that an unrecognised keyword FAILS rather than skips: a validator that silently approves what it does not understand invites reliance it cannot support. It found three things on first run. ONE, AND THE LARGEST: check_request.schema.json pointed subject.type at CARING's subject_type enum (Human, Service, ...), and no consumer sends that vocabulary. user-engine sends human, tenant-engine and secrets-engine send service, and ops-warden sends adm/agt/atm -- an actor-type vocabulary CARING does not model at all. Our published schema declared three live integrations non-conformant. A rule that outlaws shipped correct behaviour is the rule that is wrong, so the $ref is replaced with an opaque non-empty string and a description saying why. CARING's enum remains correct where it belongs: the registry's subject_manifest.yaml, where Service is right. TWO: policy_package_note, which this session added to the caring example's decision provenance, is undeclared under additionalProperties:false. Our own annotation broke the conformance it was annotating. Moved to the envelope's outer provenance. THREE: the secrets-engine fixtures carried partial approval-claims, missing binding, freshness and validity. A partial claim in a fixture is how a consumer learns the wrong shape -- the same mechanism that produced the destroy defect. They are now complete and valid against approval-engine's schema, including the now-required binding.pdp_digest, and a test validates them against that schema when the sibling repo is present. The destroy replay fixture is regenerated accordingly and the replay README's pinned digests updated, since a stale digest table is the same defect wearing a different hat. Closed the binding-mapping open item. approval-engine declined to publish a vocabulary mapping and their reasoning is better than the request: a PIP asserting secrets.kv.destroy MEANS destroy would author semantics over two vocabularies it owns neither of, and a wrong mapping silently accepts a claim approved for a different action. pdp_digest is the mapping precisely because it does not translate. It is now always present and nullable, so the destroy gate is pdp_digest non-null and equal, enforced at the PEP. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JTbVXpEiXA7mNJVpDnEPcB Assistant: claude-code Assistant-Model: opus Assistant-Process: 412054@bnt-lap001 Assistant-Session: 3968fae1-8d59-4209-9bd6-c22594b8ab19
This commit is contained in:
parent
c3ede0b494
commit
9f3e7e363a
10 changed files with 761 additions and 36 deletions
|
|
@ -109,13 +109,27 @@ and it carries no approver list. The rule was unsatisfiable — every live
|
|||
It failed closed, so it was never a hole, but it was a policy written against an
|
||||
invented shape. Corrected the same day.
|
||||
|
||||
### Open item: no published binding mapping
|
||||
### Closed: `pdp_digest` is the mapping, and there will be no table
|
||||
|
||||
The claim's `binding.action` and `binding.target` use `approval-engine`'s
|
||||
vocabulary (`secrets.kv.destroy`, `{"id": ..., "stage": ...}`), not this one
|
||||
(`destroy`, `lane:...`). No mapping between them is published, so the package
|
||||
makes no cross-check that the claim was approved for *this* action and target,
|
||||
and must not invent one — a wrong mapping would silently accept a claim approved
|
||||
for something else. Until a mapping exists that correspondence is the PEP's, via
|
||||
`binding.pdp_digest`. Worth closing before `SECRETS-WP-0007-T04` makes `destroy`
|
||||
reachable.
|
||||
`approval-engine` declined to publish an action/target mapping (their commit
|
||||
`6d0dfc8`) and was right to. A PIP asserting that `secrets.kv.destroy` **means**
|
||||
`destroy` would author policy semantics over two vocabularies it does not own —
|
||||
the same layer boundary flex-auth invoked against its own composed object — and
|
||||
the failure is asymmetric: a wrong mapping silently accepts a claim approved for
|
||||
a *different* action, which is worse than no mapping.
|
||||
|
||||
```text
|
||||
claim.binding.pdp_digest == decision.binding.request_digest
|
||||
```
|
||||
|
||||
is the mapping, and it is stronger than a name table because it does not
|
||||
translate: it compares the PDP's own digest to the PDP's own digest, in one
|
||||
vocabulary, with nobody asserting equivalence.
|
||||
|
||||
`binding.pdp_digest` is now **always present and may be null**, so its absence is
|
||||
a stated fact rather than a missing key. Null means the approval was not issued
|
||||
against a PDP decision — it proves an approval exists, not that it was issued
|
||||
against the request being decided.
|
||||
|
||||
**The `destroy` gate is therefore: `pdp_digest` non-null and equal**, enforced by
|
||||
the PEP, before `SECRETS-WP-0007-T04` makes `destroy` reachable.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue