tegwick
e8d6d08f79
B1 was found with a shell pipeline and published as a finding. The review it appeared in had already argued that a mechanical check nobody can re-run is an assertion, and §11's entire claim is mechanical checkability — so asserting B1 unmechanically was that defect committed by the repository reporting it. tools/survey_layer_declarations.go reads both §11 forms per repository, reports intra-repository disagreement, and writes a receipt. Run once, it showed the published B1 was wrong: the estate does not spell layer: three ways across repositories. The original pipeline took the first ^layer: match per repository without recording which file it came from, reporting one value where there were two. The corrected finding is stronger. Nine of nine repositories carrying both §11 forms declare a different value in each: INTENT.md says Engine/Staff, layer.yaml says engine/staff. The disagreement is within each repository, between the two forms §11 permits, and it is universal rather than careless — two generators, two conventions. Nobody is inconsistent with anybody else. That relocates the question from casing to precedence: §11 accepts either form and does not say which governs when both exist and disagree, so a conformance run reading INTENT.md and one reading layer.yaml reach different answers for nine repositories while both follow §11. flex-auth is the only declared repository that cannot exhibit this, and only because it never wrote the second file. The correction is recorded in the review rather than edited away: a published review corrected silently is FLEX-DEC-2026-008's defect, and that rule has no exception for the reviewer. Four tests cover the disagreement case, the refusal to fold case, a missing declaration, and the single-form shape that must not read as self-disagreement. The survey checks only the §3 vocabulary and never applies flex-auth's house rules to peers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Assistant: claude-code Assistant-Model: opus Assistant-Process: 28468@bnt-lap001 Assistant-Session: c76569b2-6056-4dad-aea4-49cd7a018f5d
89 lines
2.6 KiB
Go
89 lines
2.6 KiB
Go
package layer_test
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/netkingdom/flex-auth/internal/layer"
|
|
)
|
|
|
|
func writeRepo(t *testing.T, root, name, intent, declFile string) {
|
|
t.Helper()
|
|
dir := filepath.Join(root, name)
|
|
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if intent != "" {
|
|
body := "---\nlayer: " + intent + "\nrole: PDP\n---\n\n# x\n"
|
|
if err := os.WriteFile(filepath.Join(dir, "INTENT.md"), []byte(body), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
if declFile != "" {
|
|
if err := os.WriteFile(filepath.Join(dir, "layer.yaml"), []byte("layer: "+declFile+"\n"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// The finding FLEX-WP-0030 B1 rests on: §11 accepts either form and does not
|
|
// say which governs when a repository carries both and they disagree.
|
|
func TestSurveyDetectsFormsDisagreeingWithinOneRepo(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeRepo(t, root, "peer", "Engine", "engine")
|
|
|
|
rows, err := layer.SurveyDeclarations(root, []string{"peer"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(rows) != 1 {
|
|
t.Fatalf("rows = %d; want 1", len(rows))
|
|
}
|
|
if !rows[0].SelfDisagrees() {
|
|
t.Fatal("Engine vs engine across the two §11 forms was not reported as disagreement")
|
|
}
|
|
if got := len(layer.SelfDisagreeing(rows)); got != 1 {
|
|
t.Fatalf("SelfDisagreeing = %d; want 1", got)
|
|
}
|
|
}
|
|
|
|
// Case is not folded: whether §3 is case-insensitive is the open question, and
|
|
// folding here would hide the finding rather than resolve it.
|
|
func TestSurveyDoesNotFoldCase(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeRepo(t, root, "peer", "", "engine")
|
|
|
|
rows, _ := layer.SurveyDeclarations(root, []string{"peer"})
|
|
if rows[0].File.InVocabulary {
|
|
t.Fatal(`"engine" was accepted into the §3 vocabulary; the survey must not fold case`)
|
|
}
|
|
}
|
|
|
|
func TestSurveyReportsMissingDeclaration(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeRepo(t, root, "silent", "", "")
|
|
|
|
rows, _ := layer.SurveyDeclarations(root, []string{"silent"})
|
|
if rows[0].Declared() {
|
|
t.Fatal("a repository with neither form was reported as declared")
|
|
}
|
|
if got := layer.Undeclared(rows); len(got) != 1 || got[0] != "silent" {
|
|
t.Fatalf("Undeclared = %v; want [silent]", got)
|
|
}
|
|
}
|
|
|
|
// A single well-formed declaration must not be reported as disagreeing with
|
|
// itself — flex-auth is exactly this shape.
|
|
func TestSurveySingleFormIsNotDisagreement(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeRepo(t, root, "solo", "Engine", "")
|
|
|
|
rows, _ := layer.SurveyDeclarations(root, []string{"solo"})
|
|
if rows[0].SelfDisagrees() {
|
|
t.Fatal("a repository with only INTENT.md was reported as self-disagreeing")
|
|
}
|
|
if !rows[0].Intent.InVocabulary {
|
|
t.Fatal(`"Engine" was rejected from the §3 vocabulary`)
|
|
}
|
|
}
|