IB-WP-0018-T03+T04: shadow sampling + report/CLI surfacing; close IB-WP-0018
T03 — wrap_with_shadow_sampling() helper in routing.py: builds a llm-connect ShadowingAdapter around any candidate LLMAdapter with a caller-supplied baseline, grader, and QualityLedger. async_shadow=True by default so production load is not doubled; on_shadow_error escape hatch keeps caller logs informed when a baseline outage swallows the shadow path. The returned adapter is still an LLMAdapter so it slots into a RoutingPolicy rule without further code change. T04 — generation report enrichment plus a small CLI helper: - _collect_adapter_choices walks artifact provenance, groups by (stage_id, adapter_id), and surfaces calls + prompt/completion tokens per (stage, adapter) pair in a new ## Per-stage adapter choices section. Runs that did not go through the bridge have no provider_metadata.adapter_id and emit an empty list, so fixture-only reports stay terse. - summarise_quality_ledger() rolls a llm-connect QualityLedger up by (task_type, adapter_id) with mean quality, mean cost, observations, and cumulative tokens. - infospace-bench routing ledger <path> CLI prints the rollup as JSON. Five new tests cover shadow happy-path, shadow failure isolation, ledger rollup, the routing CLI, and the report's adapter-choice aggregation. Closes IB-WP-0018: T01-T05 are all done and the workplan status flips from blocked to done now that LLM-WP-0004's primitives have shipped. 144 tests pass, 1 skipped (the OpenRouter live smoke, gated as before). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
parent
0a83e908ce
commit
f818acfc62
5 changed files with 365 additions and 3 deletions
|
|
@ -15,8 +15,11 @@ from dataclasses import dataclass, field
|
|||
from typing import Any
|
||||
|
||||
from llm_connect.adapter import LLMAdapter
|
||||
from llm_connect.grading import BaselineGrader
|
||||
from llm_connect.models import RunConfig
|
||||
from llm_connect.quality import QualityLedger
|
||||
from llm_connect.routing import AdaptiveRoutingPolicy, RoutingPolicy
|
||||
from llm_connect.shadowing import ShadowingAdapter
|
||||
|
||||
from .workflow import AssistedGenerationRequest, AssistedGenerationResult
|
||||
|
||||
|
|
@ -116,6 +119,88 @@ def _identify_adapter(adapter: LLMAdapter) -> str:
|
|||
return name
|
||||
|
||||
|
||||
def wrap_with_shadow_sampling(
|
||||
*,
|
||||
candidate: LLMAdapter,
|
||||
baseline: LLMAdapter,
|
||||
grader: BaselineGrader,
|
||||
ledger: QualityLedger,
|
||||
task_type: str,
|
||||
adapter_id: str | None = None,
|
||||
baseline_adapter_id: str | None = None,
|
||||
shadow_rate: float = 0.1,
|
||||
async_shadow: bool = True,
|
||||
on_shadow_error: Any | None = None,
|
||||
) -> ShadowingAdapter:
|
||||
"""Wrap ``candidate`` with llm-connect's ``ShadowingAdapter``.
|
||||
|
||||
Sampled baseline grading collects QualityLedger observations without
|
||||
changing the response the caller sees. Errors in the shadow path
|
||||
(baseline outage, grader failure, ledger write error) never alter the
|
||||
candidate response — failures land on ``on_shadow_error`` when
|
||||
provided, else are silently swallowed by the underlying adapter.
|
||||
|
||||
The returned ``ShadowingAdapter`` is still an ``LLMAdapter``, so it
|
||||
can be slotted into a ``RoutingPolicy`` rule and used through
|
||||
``RoutingAssistedGenerationAdapter`` without further changes.
|
||||
"""
|
||||
return ShadowingAdapter(
|
||||
candidate_adapter=candidate,
|
||||
baseline_adapter=baseline,
|
||||
grader=grader,
|
||||
ledger=ledger,
|
||||
task_type=task_type,
|
||||
adapter_id=adapter_id or _identify_adapter(candidate),
|
||||
baseline_adapter_id=baseline_adapter_id or _identify_adapter(baseline),
|
||||
shadow_rate=shadow_rate,
|
||||
async_shadow=async_shadow,
|
||||
on_shadow_error=on_shadow_error,
|
||||
)
|
||||
|
||||
|
||||
def summarise_quality_ledger(
|
||||
ledger_path: str | Any,
|
||||
) -> list[dict[str, Any]]:
|
||||
"""Roll up a QualityLedger into one row per (task_type, adapter_id).
|
||||
|
||||
Useful as a CLI helper or a quick budget-style inspection without
|
||||
loading llm-connect's full ledger API at the call site.
|
||||
"""
|
||||
from pathlib import Path
|
||||
|
||||
ledger = QualityLedger(path=Path(ledger_path))
|
||||
observations = ledger.read_all()
|
||||
grouped: dict[tuple[str, str], dict[str, Any]] = {}
|
||||
for obs in observations:
|
||||
key = (obs.task_type, obs.adapter_id)
|
||||
bucket = grouped.setdefault(
|
||||
key,
|
||||
{
|
||||
"task_type": obs.task_type,
|
||||
"adapter_id": obs.adapter_id,
|
||||
"observations": 0,
|
||||
"mean_quality": 0.0,
|
||||
"mean_cost_usd": 0.0,
|
||||
"total_tokens_in": 0,
|
||||
"total_tokens_out": 0,
|
||||
},
|
||||
)
|
||||
bucket["observations"] += 1
|
||||
bucket["mean_quality"] += float(obs.quality_score)
|
||||
bucket["mean_cost_usd"] += float(obs.cost_usd)
|
||||
bucket["total_tokens_in"] += int(getattr(obs, "tokens_in", 0) or 0)
|
||||
bucket["total_tokens_out"] += int(getattr(obs, "tokens_out", 0) or 0)
|
||||
rows: list[dict[str, Any]] = []
|
||||
for bucket in grouped.values():
|
||||
count = bucket["observations"]
|
||||
if count:
|
||||
bucket["mean_quality"] = round(bucket["mean_quality"] / count, 4)
|
||||
bucket["mean_cost_usd"] = round(bucket["mean_cost_usd"] / count, 6)
|
||||
rows.append(bucket)
|
||||
rows.sort(key=lambda row: (row["task_type"], row["adapter_id"]))
|
||||
return rows
|
||||
|
||||
|
||||
def _provider_tag(adapter: LLMAdapter) -> str:
|
||||
"""Coarse provider tag matching the strings already used in run records.
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue