coulomb/key-cape
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wire tenant_roles as explicit opt-in configuration
All checks were successful
Build and Publish Container Image / build-and-push (push) Successful in 48s
Details

Browse source 
Closes gap G07. The tenant-engine client and TokenHandler.TenantEngine were
implemented and tested, but main.go supplied no client and exposed no
configuration, so the stock executable left the field nil and the capability
existed at library level only.

A tenantEngine block with baseURL and an optional timeout now wires it. An empty
baseURL leaves the stock server's behaviour exactly as it was, so enabling the
claim is a deliberate act. Validation treats a configured source as one that must
work: http/https with a host, and a timeout in (0, 10s] since it sits on the
synchronous token-issuance path. A timeout set without a baseURL is rejected
rather than ignored -- it means someone expected the claim to be on.

Verified in the built executable, which is what G07 asks for, rather than at the
wiring: against a stub source a real token carries tenant_roles; with no block
the claim is absent; with the source configured but down, issuance succeeds
without it, confirming the documented fail-open path end to end.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NV9oijZukGyGbRQGGKnK4P

Assistant: claude-code
Assistant-Model: opus
Assistant-Process: 713576@bnt-lap001
Assistant-Session: 384c511d-9bce-4cb8-a676-2aef6c0c8df6
This commit is contained in:
tegwick 2026-09-08 08:59:40 +02:00
parent 01551d9b0a
commit a0f3cac122
7 changed files with 163 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/internal/config/config_test.go
View file

@ -496,3 +496,36 @@ func TestValidateConfigAudience(t *testing.T) {
}
}
}
// tenant_roles is opt-in, but a configured cache source must be usable: it sits
// on the synchronous token-issuance path (KEY-WP-0024).
func TestValidate_TenantEngine(t *testing.T) {
cases := map[string]struct {
engine config.TenantEngineConfig
valid bool
}{
"absent is valid": {config.TenantEngineConfig{}, true},
"http url": {config.TenantEngineConfig{BaseURL: "http://tenant-engine:8080"}, true},
"https url and timeout": {config.TenantEngineConfig{BaseURL: "https://tenant-engine", Timeout: "2s"}, true},
"not a url": {config.TenantEngineConfig{BaseURL: "tenant-engine"}, false},
"wrong scheme": {config.TenantEngineConfig{BaseURL: "ldap://tenant-engine"}, false},
"unparseable timeout": {config.TenantEngineConfig{BaseURL: "http://t", Timeout: "soon"}, false},
"zero timeout": {config.TenantEngineConfig{BaseURL: "http://t", Timeout: "0s"}, false},
"timeout far too long": {config.TenantEngineConfig{BaseURL: "http://t", Timeout: "5m"}, false},
// A timeout with no base URL means someone expected the claim to be on.
"timeout without url": {config.TenantEngineConfig{Timeout: "2s"}, false},
}
for name, tc := range cases {
t.Run(name, func(t *testing.T) {
cfg := validConfig(writeTempFile(t, "key"))
cfg.TenantEngine = tc.engine
errs := config.ValidateConfig(cfg)
if tc.valid && len(errs) != 0 {
t.Fatalf("expected valid, got %v", errs)
}
if !tc.valid && len(errs) == 0 {
t.Fatal("expected a validation error")
}
})
}
}