From 0b0294acbdebe993b8ee7d7cbcc9ae45e0337c41 Mon Sep 17 00:00:00 2001 From: tegwick Date: Fri, 2 Oct 2026 22:46:42 +0200 Subject: [PATCH] =?UTF-8?q?MARKITECT-WP-0002:=20T05=20=E2=80=94=20verify?= =?UTF-8?q?=20a9a27b8=20fixes,=20bump=20testdrive-jsui=20pin?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Sonnet 5.5 Assistant: claude-code Assistant-Model: sonnet Assistant-Process: 299063@bnt-lap001 Assistant-Session: 53eb1e1c-c13a-4277-9ce2-3702960d93f7 --- capabilities/testdrive-jsui | 2 +- workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/capabilities/testdrive-jsui b/capabilities/testdrive-jsui index f17363c4..a9a27b86 160000 --- a/capabilities/testdrive-jsui +++ b/capabilities/testdrive-jsui @@ -1 +1 @@ -Subproject commit f17363c49193415f1d8872544d393dbd7a909734 +Subproject commit a9a27b86bb726a75d22ed013f5c4db1b59a7faa5 diff --git a/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md b/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md index 74df5198..544fec86 100644 --- a/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md +++ b/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md @@ -112,6 +112,8 @@ state_hub_task_id: "94dd2a30-fa38-471e-b19a-ed0913579524" 2026-10-02 (progress, standalone `f17363c`, clean `npm ci`): Jest 68/68; `build:prod` ok; `npm pack` = 15 files, 452.6 kB, `types/index.d.ts` included; `npm publish --dry-run` completes (nothing published). **Fails:** (1) lint 1,172 problems (860 `indent`); (2) packed-tarball consumer test: `import` and `require` both fail in Node (`exports is not defined in ES module scope`) because `type: module` + CommonJS `main` named `.cjs.js`; no `exports` map; (3) CHANGELOG not in tarball; (4) publish dry-run warns npm auto-corrects package.json (`npm pkg fix`). Asked markitect-tool to fix (2)-(4); lint decision and a browser smoke test remain. T05 stays progress until these pass. +2026-10-02 (update, standalone `a9a27b8`, pin bumped): markitect-tool fixed (2)-(4): CJS now emitted as `.cjs`, `exports` map added (types/import/require/browser, `./style.css`), `npm pkg fix` applied, CHANGELOG in the tarball (15 files), `npm publish --dry-run` no longer warns about package.json. Also fixed a second bug found by that test: bundles threw `ControlBase is not defined` on load because controls skipped their `window.X =` assignment under a bundler. Independently re-verified here from a fresh `npm ci` and packed tarball: Jest 68/68; ESM `import` and CJS `require` load with a browser-like `window` (=globalThis, jsdom document); the min UMD bundle loads in a jsdom window and exposes `TestDriveJSUI`, `ControlBase`, `EditControl`. Caveats: the library is browser-only (plain Node import still throws; `indexedDB` unhandled rejection after load); Jest tests source, not `dist`, and no tarball regression test exists yet. **Still open for T05:** lint (1,172 problems, 860 `indent`); stale `github.com/markitect` URLs in package.json/pyproject.toml; no real-browser smoke test. T06 must not tag until lint is resolved or explicitly waived. + ## P.5 — Create v1.0.0 release tag ```task