From 8f7c1026bbd776b2a82e8bb543d03e9c01c71d2b Mon Sep 17 00:00:00 2001 From: tegwick Date: Sat, 3 Oct 2026 00:06:03 +0200 Subject: [PATCH] MARKITECT-WP-0002: T05 done (lint clean, smoke + consumer tests pass), T06 unblocked; plan retired; pin 3d57638 Co-Authored-By: Claude Sonnet 5.5 Assistant: claude-code Assistant-Model: sonnet Assistant-Process: 299063@bnt-lap001 Assistant-Session: 53eb1e1c-c13a-4277-9ce2-3702960d93f7 --- capabilities/testdrive-jsui | 2 +- workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/capabilities/testdrive-jsui b/capabilities/testdrive-jsui index c79cfd19..3d576386 160000 --- a/capabilities/testdrive-jsui +++ b/capabilities/testdrive-jsui @@ -1 +1 @@ -Subproject commit c79cfd19c96bd088227b0bc6181e8f960e988978 +Subproject commit 3d576386a0f16658a5fe2377ff4f31dd6a717ccd diff --git a/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md b/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md index 19f6760f..d9f63d97 100644 --- a/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md +++ b/workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md @@ -103,13 +103,15 @@ state_hub_task_id: "d700098c-449d-44ba-ab02-cc3571bf6587" ```task id: MARKITECT-WP-0002-T05 -status: progress +status: done priority: high state_hub_task_id: "94dd2a30-fa38-471e-b19a-ed0913579524" ``` 2026-09-28: Waiting for P.2/P.3 and standalone package fixes: resolve the missing advertised declaration file and verify ESM, CommonJS, browser and CSS consumption from an actual packed tarball. Run lint, tests, production build and publish dry-run; retain artifact evidence. +2026-10-03: **Done** at standalone `3d57638` (pin bumped). Evidence: clean `npm ci`; `npm run lint` 0 errors (120 warnings: `no-console` etc.); Jest 67 passed + 1 todo; `build:prod` ok; `npm pack` 15 files incl. CHANGELOG, LICENSE, README, `dist/*`, `types/index.d.ts`; packed-tarball consumer (marked@13 + jsdom, window=globalThis): ESM `import` ok, CJS `require` ok, `testdrive-jsui/style.css` resolves; `npm publish --dry-run` completes with no manifest warning (only the expected not-logged-in notice); headless-Chromium edit smoke test through `markitect md-render --edit` passes. `npm view testdrive-jsui` returns 404, so the name is unclaimed. Lint cleanup details: unused variables removed, one chai-style test converted to Jest, and the vacuous 'prevent event bubbling' test became `test.todo` (it asserted nothing and is false against its mock DOM). Per-test lint rules for unused vars / conditional expect are warnings for test files only. STANDALONE_PLAN.md retired as **dropped** (Bernd, 2026-10-03). Remaining before publish: stale `github.com/markitect` URLs in package.json/pyproject.toml (real forge/homepage URL not established), CHANGELOG 1.0.0 is dated 2025-12-16 and the fixes sit under Unreleased (T06 aligns this), and the smoke script is not committed. + 2026-10-02 (progress, standalone `f17363c`, clean `npm ci`): Jest 68/68; `build:prod` ok; `npm pack` = 15 files, 452.6 kB, `types/index.d.ts` included; `npm publish --dry-run` completes (nothing published). **Fails:** (1) lint 1,172 problems (860 `indent`); (2) packed-tarball consumer test: `import` and `require` both fail in Node (`exports is not defined in ES module scope`) because `type: module` + CommonJS `main` named `.cjs.js`; no `exports` map; (3) CHANGELOG not in tarball; (4) publish dry-run warns npm auto-corrects package.json (`npm pkg fix`). Asked markitect-tool to fix (2)-(4); lint decision and a browser smoke test remain. T05 stays progress until these pass. 2026-10-02 (update, standalone `a9a27b8`, pin bumped): markitect-tool fixed (2)-(4): CJS now emitted as `.cjs`, `exports` map added (types/import/require/browser, `./style.css`), `npm pkg fix` applied, CHANGELOG in the tarball (15 files), `npm publish --dry-run` no longer warns about package.json. Also fixed a second bug found by that test: bundles threw `ControlBase is not defined` on load because controls skipped their `window.X =` assignment under a bundler. Independently re-verified here from a fresh `npm ci` and packed tarball: Jest 68/68; ESM `import` and CJS `require` load with a browser-like `window` (=globalThis, jsdom document); the min UMD bundle loads in a jsdom window and exposes `TestDriveJSUI`, `ControlBase`, `EditControl`. Caveats: the library is browser-only (plain Node import still throws; `indexedDB` unhandled rejection after load); Jest tests source, not `dist`, and no tarball regression test exists yet. **Still open for T05:** lint (1,172 problems, 860 `indent`); stale `github.com/markitect` URLs in package.json/pyproject.toml; no real-browser smoke test. T06 must not tag until lint is resolved or explicitly waived. @@ -122,9 +124,7 @@ state_hub_task_id: "94dd2a30-fa38-471e-b19a-ed0913579524" ```task id: MARKITECT-WP-0002-T06 -status: wait -depends_on: [MARKITECT-WP-0002-T05] -blocking_reason: "Tag only a verified candidate (P.4)." +status: todo priority: medium state_hub_task_id: "d7c2ce00-00ad-431c-b036-64e727e49e48" ```