coulomb/markitect-main
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MARKITECT-WP-0002: T05 — lint fix, browser smoke test, two integration bugs fixed; pin c79cfd1
All checks were successful
CI Smoke / host-smoke (push) Successful in 0s
Details
CI Smoke / container-smoke (push) Successful in 2s
Details

Browse source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Assistant: claude-code
Assistant-Model: sonnet
Assistant-Process: 299063@bnt-lap001
Assistant-Session: 53eb1e1c-c13a-4277-9ce2-3702960d93f7
This commit is contained in:
tegwick 2026-10-02 23:10:04 +02:00
parent 6314767ab1
commit 913dae1dd5
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
capabilities/testdrive-jsui

@ -1 +1 @@
Subproject commit a9a27b86bb726a75d22ed013f5c4db1b59a7faa5
Subproject commit c79cfd19c96bd088227b0bc6181e8f960e988978

4
workplans/MARKITECT-WP-0002-testdrive-jsui-publication.md
View file

@ -114,6 +114,10 @@ state_hub_task_id: "94dd2a30-fa38-471e-b19a-ed0913579524"
2026-10-02 (update, standalone `a9a27b8`, pin bumped): markitect-tool fixed (2)-(4): CJS now emitted as `.cjs`, `exports` map added (types/import/require/browser, `./style.css`), `npm pkg fix` applied, CHANGELOG in the tarball (15 files), `npm publish --dry-run` no longer warns about package.json. Also fixed a second bug found by that test: bundles threw `ControlBase is not defined` on load because controls skipped their `window.X =` assignment under a bundler. Independently re-verified here from a fresh `npm ci` and packed tarball: Jest 68/68; ESM `import` and CJS `require` load with a browser-like `window` (=globalThis, jsdom document); the min UMD bundle loads in a jsdom window and exposes `TestDriveJSUI`, `ControlBase`, `EditControl`. Caveats: the library is browser-only (plain Node import still throws; `indexedDB` unhandled rejection after load); Jest tests source, not `dist`, and no tarball regression test exists yet. **Still open for T05:** lint (1,172 problems, 860 `indent`); stale `github.com/markitect` URLs in package.json/pyproject.toml; no real-browser smoke test. T06 must not tag until lint is resolved or explicitly waived.
2026-10-02 (update, standalone `c79cfd1`, pin bumped): Bernd approved the format fix. `eslint --fix` (semi, indent 4) applied in `652cb4e`, cross-file browser globals declared in the eslint config (`de47bf1`): lint 1,172 → 134 problems (**47 errors**, 87 warnings). The remaining 47 are not formatting: unused variables and `jest/no-conditional-expect` / `valid-expect` in tests, plus `new-cap`, `no-cond-assign`, `no-prototype-builtins`. Lint is therefore still not a clean gate; fix or waive before T06. Jest 68/68, build ok, pack 15 files, `publish --dry-run` completes.
**Browser smoke test (done, headless Chromium via Playwright, `markitect md-render --edit` output):** page loads with no page errors; `marked`, `ControlBase`, `EditControl`, `MarkitectDebugSystem` defined; clicking a section opens the editor with the right markdown; Accept re-renders the section (edited text and `<em>` present), editor closes. The test found two pre-existing bugs (present at the original pin `b8f13b4`), both fixed in the standalone repo: `172660c` `js/core/debug-system.js` ended with an ES `export`, a SyntaxError as a classic `<script>`, so `window.MarkitectDebugSystem` was never set under Markitect; `c79cfd1` `setupEventHandlers` in `js/main-updated.js` returned early on missing `documentControls`, so `changes-accepted` was never wired and accepted edits never refreshed the page. Not covered: the published-package (CDN/`dist`) path, because Markitect loads the source files; that is T08's job. The smoke script is not committed anywhere yet (scratch only).
## P.5 — Create v1.0.0 release tag
```task