tegwick
bf6a44db6d
Assistant: codex Assistant-Model: gpt-6.1-sol Assistant-Session: 01a126e1-76f8-7643-8cf3-e93336539ade
74 lines
5.4 KiB
JSON
74 lines
5.4 KiB
JSON
{
|
|
"reviewer": "net-kingdom-owner (agent net-kingdom, codex)",
|
|
"decision": "approved",
|
|
"review_id": "NK-REVIEW-20261011-KEY39-NODE-ROUTE-INPUT-SOURCE",
|
|
"work_item_id": "NK-WP-ADHOC-2026-10-11-T07",
|
|
"reviewed_manifest_sha256": "90aabec336008d7d51e37c04b5ff96ba8ed6630821cca1a4c333d803367247f7",
|
|
"reviewed_proposal_id": "KEY-WP-0039-T02/attended-lifecycle-v7-node-route-input",
|
|
"reviewed_source_hashes": {
|
|
"sso-mfa/k8s/keycape/openbao-negative-session.py": "4c90edb541b5ea2ff131c3e674c80197c358c2f81140187028e57de0ac8dbf81",
|
|
"sso-mfa/k8s/keycape/test_openbao_negative_session.py": "01e23f2b4fc77824a161a57acb3a52d19aad846b3b6c0fd3abd81afa1dc2985c",
|
|
"sso-mfa/k8s/keycape/test_openbao_node_route.py": "02a715dcc028d0cacbf3b0ffdf705758438717f064e290b283f8e773540dd2d7",
|
|
"sso-mfa/k8s/keycape/openbao-negative-node-route.md": "ff3604380a616dfaa86cd9aaa1f131136ee4fc751397a1ebda3a8d737e3c5346"
|
|
},
|
|
"previous_review_sha256": "d011b8945dab70b4d7965baea826b8983993e8b8c04ca72d43f52b7c039e84ce",
|
|
"comment": "NetKingdom INTENT Principles 6/7 require bounded exposure and explicit owner responsibility. Exact v7 manifest 90aabec336008d7d51e37c04b5ff96ba8ed6630821cca1a4c333d803367247f7 prepared/reviewed under completed same-trial NK-WP-ADHOC-2026-10-11-T07. Corrects prior v6 documentation overstatement by gating actual main private-input consumption on source/approval/public-health readiness and preserving the original execution deadline. Authored owner source preparation only; fresh independent KeyCape/Platform exact reviews and founder native authority remain required.",
|
|
"findings": [],
|
|
"validation": {
|
|
"supplied_lifecycle_tests": 46,
|
|
"node_route_and_actual_main_tests": 12,
|
|
"retained_independent_tests": 21,
|
|
"unchanged_runner_tests_previously_verified": 17,
|
|
"all_passed": true,
|
|
"synthetic_offline_only": true,
|
|
"new_main_checks": [
|
|
"failed public health leaves private stdin unread in execute/recover",
|
|
"missing approved health pin leaves stdin unread",
|
|
"successful public health occurs before stdin.read; execution receives already-started window",
|
|
"expired preinput monotonic window refuses before runner/native access and cannot renew"
|
|
],
|
|
"pre_freeze_refinements": [
|
|
"Initial test fixture accidentally included absent synthetic runner source pin; corrected fixture to exact local source envelope.",
|
|
"New actual preinput budget test caught missing global CLEANING declaration after window initialization refactor; fixed before source freeze. All final suites pass."
|
|
],
|
|
"original_checkout_source_pins": {
|
|
"sso-mfa/k8s/keycape/openbao-negative-session.py": "3bcceebc845b17492040c76223d77088257c547a2b890198e7b5c2b04a0cd360",
|
|
"sso-mfa/k8s/keycape/test_openbao_negative_session.py": "a428a4a5ea60bd6c4ad10481e133227ad696a4a08653bf39b554b47431fb9f8c"
|
|
}
|
|
},
|
|
"coverage": [
|
|
"Workstation bridge configuration routing metadata and actual -L implementation distinguish node/workstation listener",
|
|
"No node Pod DNS assumption; bounded founder foreground node-local gateway Service port-forward proposal and process-specific teardown",
|
|
"Public unauth GET only; strict active initialized/unsealed body and digest-only cluster identity evidence",
|
|
"Execute initial route refusal before native/Secret access; repeated route loss after dry-runs before first mutation",
|
|
"Separate recovery route gate before native/Secret reads; health identity must match exact envelope pin",
|
|
"No auth headers, private stdin or Kubernetes in public route-preflight mode; current-process diagnostic does not attest node placement",
|
|
"HTTP health shares all existing no-proxy/no-redirect/byte/total-timer/abort guards; slow-health real timer refusal",
|
|
"All earlier CAS/deadline/deletion/recovery/known-revoke/unknown-outcome regressions remain",
|
|
"Actual main failure tests, not only execute-function mocks: unavailable route and missing health pin prevent stdin.read; recover also consumes no stdin",
|
|
"Actual main success ordering verifies health before stdin before execution; original pre-input monotonic window is preserved",
|
|
"Source/role/authority revalidation follows private input; expired original monotonic window refuses before runner/native access"
|
|
],
|
|
"native_prerequisites": [
|
|
"Fresh exact source reviews by Platform and KeyCape",
|
|
"Founder exact source/runtime/route/window/cleanup decision",
|
|
"Actual same-node route preflight with owner-admitted route and independently confirmed provider identity",
|
|
"Exact envelope bao_health_identity_sha256 from current founder preflight; fresh owner role/policy/leeway observation",
|
|
"Admitted private human/coding-agent token producer remains separate gap",
|
|
"Current headroom/quiet window and actual native negative/revoke/restoration/cleanup acceptance"
|
|
],
|
|
"authority_boundary": {
|
|
"source_preparation_only": true,
|
|
"native_actions": false,
|
|
"tunnel_opened": false,
|
|
"node_reachability_observed": false,
|
|
"owner_checkout_writes": false,
|
|
"credential_access": false,
|
|
"secret_reads": false,
|
|
"foreign_reviews": false,
|
|
"founder_approval": false,
|
|
"KEY39_task_closure": false
|
|
},
|
|
"work_record_anchor_sha256": "717b8c9c80553be09fbdc8ddc6e8aaf72be830fe7763da227b8695e463bea631",
|
|
"retained_correction_history": "V6 and its original reviews remain unchanged; its main had read private stdin before execute health, despite broader documentation. V7 is a same-trial refinement, not a backfilled unchanged success."
|
|
}
|