ops-warden/tests/test_layer_conformance.py

"""Layer-model conformance (security-layer-model_v0.4 §5, §11).

Two things are checked here. §11 makes one of them mechanical: every direct
Tooling client maps to a declared shape. §5.2 asks for the other: the conduit's
supplied-authority property covered by a test.

Deliberately absent: any assertion on a §5.3 review date. A date-triggered
failure breaks the build on a calendar day with no code change, punishing
whoever commits next rather than whoever owns the gap — the same reasoning
recorded in WARDEN-WP-0033-T05 for blocker staleness.
"""
from __future__ import annotations

import os
import subprocess
import sys
from pathlib import Path

import yaml

ROOT = Path(__file__).resolve().parents[1]


def _decl() -> dict:
    return yaml.safe_load((ROOT / "layer.yaml").read_text())


class TestDeclaration:
    def test_declares_staff_layer_in_its_own_voice(self):
        d = _decl()
        assert d["repository"] == "ops-warden"
        assert d["layer"] == "staff"
        # §11: "only the repository's own file, in its own voice, conforms."
        assert d["declared_by"] == "docs/adr/ADR-0010"

    def test_every_tooling_contact_maps_to_a_declared_shape(self):
        """§11 mechanical check — the guard against a new undeclared client."""
        result = subprocess.run(
            [sys.executable, str(ROOT / "scripts" / "check_layer_conformance.py")],
            capture_output=True,
            text=True,
        )
        assert result.returncode == 0, (
            f"undeclared Tooling contact — a finding under §11, not a tracked gap:\n"
            f"{result.stdout}{result.stderr}"
        )

    def test_declared_gaps_carry_all_four_fields(self):
        """§5.3 is machine-readable or it is prose wearing a schema."""
        for c in _decl()["tooling_contacts"]:
            if c["shape"] == "5.3":
                for field in ("capability", "intended_owner", "blocked_on", "review"):
                    assert c.get(field), f"{c['id']} missing {field}"

    def test_gaps_are_not_counted_as_conformance(self):
        """§11: a declared gap is tracked non-conformance. Keep that visible."""
        text = (ROOT / "layer.yaml").read_text()
        assert "TRACKED NON-CONFORMANCE" in text.upper()


class TestConduitSuppliesNoAuthority:
    """§5.2: 'MUST NOT present its own credential, MUST NOT widen what the
    caller could already do.' The standard says this SHOULD be covered by a
    test; this is that test."""

    def test_conduit_supplies_no_authority_of_its_own(self, monkeypatch):
        from warden import proxy

        monkeypatch.setenv("VAULT_TOKEN", "caller-own-token")
        monkeypatch.setenv("HOME", "/home/nobody")
        before = dict(os.environ)

        env = proxy._caller_env()

        # The child environment IS the caller's environment — nothing added,
        # nothing removed, no ops-warden credential injected.
        assert env == before, (
            "conduit altered the caller's environment; §5.2 requires it to "
            "supply no authority of its own"
        )
        assert env["VAULT_TOKEN"] == "caller-own-token"

    def test_conduit_declares_supplied_authority_none(self):
        conduits = [c for c in _decl()["tooling_contacts"] if c["shape"] == "5.2"]
        assert conduits, "no §5.2 conduit declared — proxy.py is one"
        for c in conduits:
            assert c["supplied_authority"] == "none"

    def test_proxy_holds_no_credential_constant(self):
        """A conduit that presents its own token is not a conduit (§5.2)."""
        src = (ROOT / "src" / "warden" / "proxy.py").read_text()
        # It may name token ENV VARS to detect caller auth; it must not carry a
        # token value or mint one.
        for forbidden in ("X-Vault-Token", "auth/approle/login", "token create"):
            assert forbidden not in src, (
                f"proxy.py references {forbidden!r} — that is presenting or "
                f"minting authority, not conducting the caller's"
            )