feat: refuse to answer a write with a read (WARDEN-WP-0038)

`warden plan` scored needs by keyword overlap with no notion of what the
caller wanted to DO, so "generate a successor secret and CAS-write it to two
custodians" matched the lane that READS that path and inherited its
`autonomous` verdict -- answered with --out/--exec/--wrap.

Two counterparties reported it in two days. key-cape distrusted the output on
principle and was right to; railiance-platform, answering as the write
authority being wrongly bypassed, said plainly that `founder_required` is the
verdict it should have returned and that until it is fixed a plan result must
not stand in for the owner's answer.

A mutating need on a lane ops-warden does not permanently own can no longer
reach any branch returning `autonomous`: it becomes `founder_required` with
an approve act naming the write owner, or `unroutable` with a CCR stub when
the lane admits no rotation route. Commands carry no read transport either
way, which is the half that made the wrong verdict actionable.

The ownership test does the work a verb list cannot. SSH certificate
issuance is itself a mutating act, so `delegation.mode: permanent` -- not the
absence of a verb -- separates ops-warden's own front door from someone
else's custody. A regression asserts `warden sign` still proceeds; a guard
that refused our own lane would be worse than the defect it fixes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013EPuTc18FjU5WFqoSEKH3C

Assistant: claude-code
Assistant-Model: opus
Assistant-Process: 1276224@bnt-lap001
Assistant-Session: 426ec497-e1c4-4dd3-b417-dfce1ca1dbc3
This commit is contained in:
tegwick 2026-09-10 08:02:10 +02:00
parent 9c01a8a212
commit 66db87e6ae
3 changed files with 257 additions and 2 deletions

View file

@ -119,3 +119,87 @@ def test_cli_plan_json():
assert payload["verdict"] == "autonomous"
assert payload["organization_posture"] == "build"
assert payload["lane_id"] == "agent-harness-forgejo-deploy"
# --- mutate intent (WARDEN-WP-0038) -------------------------------------------
#
# `warden plan` scored a need by keyword overlap with no notion of what the
# caller wanted to DO, so "generate a successor secret and CAS-write it to two
# custodians" matched the lane that READS that path and inherited its
# `autonomous` verdict, answered with --out/--exec/--wrap. Reported independently
# by key-cape (2026-09-08) and railiance-platform (2026-09-09), who added: "this
# is the same verdict your warden plan should have returned; until that is fixed,
# do not let a plan result stand in for this answer."
QONTO_ROTATION_NEED = (
"generate a successor client secret for rapp-qonto keycape client and "
"CAS-write it to OpenBao platform/workloads/rapp-qonto/keycape-client "
"and sso/keycape-rapp-qonto-client"
)
def test_reported_qonto_write_no_longer_returns_autonomous():
"""The exact need from the report. Regression, in the manner of WP-0033-T06."""
plan = build_plan(QONTO_ROTATION_NEED)
assert plan.verdict == "founder_required"
assert plan.lane_id == "rapp-qonto-keycape-client"
assert plan.founder_act is not None
assert plan.founder_act.kind == "approve"
assert plan.founder_act.details["write_owner"] == "key-cape"
def test_a_write_need_is_never_answered_with_a_read_transport():
"""The half that made the wrong verdict actionable rather than merely wrong."""
plan = build_plan(QONTO_ROTATION_NEED)
joined = " ".join(plan.commands)
for read_transport in ("--out", "--wrap", "--fetch", "bao kv get", "--exec"):
assert read_transport not in joined, read_transport
def test_mutating_need_names_why_it_escalated():
"""WP-0029's property: a verdict carries the reasons that produced it."""
plan = build_plan(QONTO_ROTATION_NEED)
assert any("change a credential" in r for r in plan.reasons)
assert any("write authority" in r for r in plan.reasons)
# The lane records automatable: false; a driver must be told so.
assert any("not automatable" in r for r in plan.reasons)
def test_ops_warden_still_proceeds_autonomously_on_the_lane_it_owns():
"""Signing IS a mutating act. The test is ownership, not the absence of a verb.
`delegation.mode: permanent` is the whole distinction if this ever fails,
the guard has started refusing ops-warden's own front door.
"""
for need in (
"sign an ssh certificate for agt-state-hub-bridge",
"issue a short-lived ssh cert for adm",
):
plan = build_plan(need)
assert plan.verdict == "autonomous", need
assert plan.lane_id == "ssh-cert-host-access"
def test_reading_the_same_lane_is_unaffected():
plan = build_plan("I need the npm token to publish whynot-design")
assert plan.verdict == "autonomous"
assert plan.lane_id == "whynot-design-npm-publish"
@pytest.mark.parametrize(
"verb", ["rotate", "revoke", "regenerate", "reset", "replace"]
)
def test_mutating_verbs_escalate_on_a_lane_ops_warden_does_not_own(verb):
plan = build_plan(f"{verb} the forgejo admin api token")
assert plan.verdict == "founder_required"
assert plan.founder_act.details["write_owner"] == "railiance-platform"
def test_intent_classifier_matches_tokens_not_substrings():
from warden.plan import _need_intent
assert _need_intent("rotate the forgejo token") == "mutate"
assert _need_intent("CAS-write to two custodians") == "mutate"
# "created" and "updated" are not the verbs; a need describing state is a read.
assert _need_intent("read the token created for whynot-design") == "read"
assert _need_intent("which subsystem owns the npm token") == "read"