From 93eab105cdad0229f0349931589d3deec3bf90a4 Mon Sep 17 00:00:00 2001 From: tegwick Date: Thu, 15 Oct 2026 01:58:17 +0200 Subject: [PATCH] Record independent attended reader custody reviews Assistant: codex Assistant-Model: gpt-6.1-sol Assistant-Session: 01a137ca-5c77-7a71-b9ae-23ad9b0b5684 --- ...forge-owner-attended-runner-review-r2.json | 35 +++++++++++++ ...forge-owner-attended-runner-review-r3.json | 52 +++++++++++++++++++ ...07-reuse-private-reader-contract-review.md | 18 +++++++ 3 files changed, 105 insertions(+) create mode 100644 docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r2.json create mode 100644 docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r3.json diff --git a/docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r2.json b/docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r2.json new file mode 100644 index 0000000..c82397c --- /dev/null +++ b/docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r2.json @@ -0,0 +1,35 @@ +{ + "reviewer": "railiance-forge-owner (agent railiance-forge, codex)", + "decision": "changes_requested", + "comment": "FORGE-WP-0007-T03; INTENT Core Principle4 Stable Handoffs and provider contract require exact approved policy bytes and truthful verified custody result. Quietcapture, unchanged ESO900second role, exact conditional twofield CCR transition and approvalbeforeprivilegedreads are supported by12tests; mutablepolicyfilepath and idempotent skipped policyrecheck need correction before approved owner review. Preparation only, no founder/live authorization.", + "reviewed_artifacts": { + "scripts/apply-reuse-surface-reader-custody.py": "179bd66fc53b99f293ff8dc1fc5f9de004391e2e71705b468ca743c0cfb46600", + "tests/test_reuse_surface_reader_custody_apply.py": "6b272b8c8be488594e43607f99a413595ec37e09900e60119f8f168c57e0c253", + "docs/proposals/2026-10-15-reuse-private-reader/conditional-approved-ccr-state-candidate-r1.json": "178dd2aeddf3544438d584fa16e3ceb1a541a357d4dff5b8b4b0e95db2f357ac", + "docs/proposals/2026-10-15-reuse-private-reader/attended-custody-handoff-r1.json": "35962e2c39e92897fe479f2194dee2c832275978d435f9147498c9d6882b8fec", + "docs/proposals/2026-10-15-reuse-private-reader/platform-attended-runner-review-r1.json": "02e7d947dc14e1ab3f20258b2e882e9253fef5e9c5685097a047a88f97442729" + }, + "tests": "12 passed independently; additional adversarial no-recheck fixture demonstrates gap", + "findings": [ + { + "id": "FORGE-CUST81-RUNNER-F01", + "summary": "Policywrite rereads mutable repo filepath after approval hash; approved policy bytes are not the executed snapshot.", + "required_change": "After envelope/bootstrap approvals verify exact policybyte snapshot hash then pass snapshot via stdin to bao policy write POLICY -, not mutable filepath. Test changing repository file after verifiedsnapshot leaves executedbytes exact." + }, + { + "id": "FORGE-CUST81-RUNNER-F02", + "summary": "When current==desired, execute never rereads policy before terminal; concurrent drift can report verified despite no final check.", + "fixture": { + "preflight_current": "desired", + "preflight_desired": "desired", + "later_policy": "concurrently_drifted", + "policy_recheck_calls": 0, + "terminal_outcome": "policy_and_custody_verified_delivery_pending" + }, + "required_change": "Check installedACL matches intendedold/exact state before credentialroute in allbranches, and final exactACL+unchangedrole before terminal. Stopon drift without implicitrewrite/retry. Preserve noCAS attendedserialization limitation." + } + ], + "live_credentials": false, + "live_mutations": false, + "approval_recorded": false +} diff --git a/docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r3.json b/docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r3.json new file mode 100644 index 0000000..e76133c --- /dev/null +++ b/docs/proposals/cust81-private-reader/forge-owner-attended-runner-review-r3.json @@ -0,0 +1,52 @@ +{ + "reviewer": "railiance-forge-owner (agent railiance-forge, codex)", + "decision": "approved", + "comment": "FORGE-WP-0007-T03; INTENT Stable Handoffs and dependable forge operational contracts. Independently approve attended custody runner R3 bounded preparation: exact hash-verified immutable policy snapshot is passed through stdin; before and after retained Forgejo bootstrap all branches verify desired ACL and unchanged900second ESO claims; no rolewrite, delivery or consumer rollout. Exact two-field CCR transition remains conditional on real supervisor disposition and installed claim proof. This owner review is not founder approval or live proof.", + "reviewed_revision": 3, + "reviewed_at": "2026-10-14T23:56:07.949483+00:00", + "work_item": "FORGE-WP-0007-T03", + "reviewed_artifacts": { + "scripts/apply-reuse-surface-reader-custody.py": "934b421c357e154f6508ab4b7c30f1aadfea2bf9a2f187d83968928d5eecad42", + "tests/test_reuse_surface_reader_custody_apply.py": "cb2c4b5f8a96cfb71015d94c5d51de0e1bbf5c8e3d90e866b207a070c1a7a266", + "docs/proposals/2026-10-15-reuse-private-reader/conditional-approved-ccr-state-candidate-r1.json": "178dd2aeddf3544438d584fa16e3ceb1a541a357d4dff5b8b4b0e95db2f357ac", + "docs/proposals/2026-10-15-reuse-private-reader/attended-custody-handoff-r1.json": "1247ad5aa73289a26a48e999b870ce2d60abb409132783e14456ea318689acff", + "docs/proposals/2026-10-15-reuse-private-reader/platform-attended-runner-review-r1.json": "2406b70ed5a0fe755fe967d3568fabffc84396bb5509c55417aa6900dbb9a4d9" + }, + "retained_bootstrap_artifacts": { + "scripts/provision-reuse-surface-forgejo-source.py": "abf60a754596baa1610d23b1fd367385b0222ac8aeaebba0f2cfb7ec4c62055b", + "scripts/revoke-reuse-surface-forgejo-source.py": "f78d1b26fbff93c6cc481a896d9fb9b9ce93049b8b3267fa41a64bc57dadb162", + "docs/proposals/2026-10-15-reuse-private-reader/bootstrap-contract.json": "2bb72671e0a5f230497ab8ef2967a20ee68d1f2cf081f07c84f6db3442e18d8b", + "openbao/policies/workload-kv-read-reuse-surface-runtime-eso.hcl": "6320f6c2d262d924ea16291d301d5f9eeb7efdb6ce7ea141c1a41d277d86b01b" + }, + "validation": { + "runner_tests": 17, + "all_reader_tests": 45, + "result": "passed independently rerun", + "manifest_hashes": "all5match", + "actual_current_ccr_sha256": "90522912fb78fed72e625382fb7114a0e9aafe76d59e36bffecab83c5bb7d643", + "conditional_future_ccr_sha256": "23039fae6137e7bdd71de0ed3278596b1ed60ae636018eb4bfcc83e53c4ada02", + "candidate_not_installed": true + }, + "resolved_findings": [ + { + "id": "FORGE-CUST81-RUNNER-F01", + "resolution": "approval_envelope retains approvedpolicyhash; execute after baseapproval reads snapshot and checks hash; Bao policywrite consumes stdin snapshot only. Replacement after snapshot cannot affect executedbytes; replacement before snapshot fails beforewrite." + }, + { + "id": "FORGE-CUST81-RUNNER-F02", + "resolution": "verify_ready desiredsnapshot ACL+immutable role runs before and after bootstrap including idempotent paths. Tests deny beforebootstrap ACLdrift and prevent verifiedterminal after ACL/roledrift." + } + ], + "r2_changes_requested_receipt": "forge-owner-attended-runner-review-r2.json", + "r2_receipt_sha256": "c4e61cd185bfc738fe8e2f7e89b71408ed35d441dfa38183cd83bad9c0832445", + "scope_limits": [ + "OpenBao ACL lacks atomicCAS; immediate predecessor recheck and successor verification are bounded attendedguards. Concurrent otheractor writes remain owner serialization constraint, not claimed atomictransaction.", + "Conditional local CCR candidate is unapplied; no statusapproval or boundclaims proof inferred from preparation.", + "Sanctioned attended Warden lane owns browser/login/revocation; nested retained Forgejo route outputcaptured; no defaultadmin/rootfallback.", + "Real founder approval, attended installedrole/ACL proof, scoped target grant/custody receipts and separately approved apps delivery/rollout remain pending." + ], + "live_credentials": false, + "live_mutations": false, + "founder_approval_recorded": false, + "same_trial": "CCR-2026-0046 reviewed refinement under sameFORGE-WP-0007-T03; R2 failures retained, not unchanged-success promotion." +} diff --git a/workplans/FORGE-WP-0007-reuse-private-reader-contract-review.md b/workplans/FORGE-WP-0007-reuse-private-reader-contract-review.md index 11dd97d..715ec50 100644 --- a/workplans/FORGE-WP-0007-reuse-private-reader-contract-review.md +++ b/workplans/FORGE-WP-0007-reuse-private-reader-contract-review.md @@ -61,3 +61,21 @@ rerun28tests pass. Original R2 review preserved verbatim in `forge-owner-review-r2-before-recovery.json` with exact refresh diff/receipt. Recovery approval, manual due-date record and authenticated execution proof stay pending owner execution; no KV removal or remint is part of recovery. + +## Independently review attended custody runner and conditional CCR transition + +```task +id: FORGE-WP-0007-T03 +status: done +priority: high +``` + +Preparation review only. R2 changes requested for exactpolicy snapshot input and +complete installedACL/immutable role verification in idempotent and mutation +paths. 12 existing boundarytests pass; independent driftfixture demonstrates +missed policyrecheck before terminal. No liveclaims or founderapproval inferred. + +R3 final preparation owner review approved in `forge-owner-attended-runner-review-r3.json`. +Independent45tests (17runner) pass; R2 changes_requested and exactartifact +receipt remain preserved. Snapshot stdin and before/after ACL+immutable role +checks resolve both confirmed defects. Conditional approvedCCR remains unapplied.