Approve corrected whynot CCR
This commit is contained in:
parent
00fb93544c
commit
06f2f4e315
2 changed files with 10 additions and 4 deletions
|
|
@ -3,7 +3,7 @@ kind: credential-change-request
|
||||||
schema_version: 1
|
schema_version: 1
|
||||||
request_type: workload-kv-read
|
request_type: workload-kv-read
|
||||||
title: whynot-design npm publish token lane
|
title: whynot-design npm publish token lane
|
||||||
status: proposed
|
status: approved
|
||||||
created: '2026-06-27'
|
created: '2026-06-27'
|
||||||
updated: '2026-06-28'
|
updated: '2026-06-28'
|
||||||
requester:
|
requester:
|
||||||
|
|
@ -33,6 +33,11 @@ review:
|
||||||
The previous approval covered platform/workloads/whynot-design/whynot-design/npm-publish
|
The previous approval covered platform/workloads/whynot-design/whynot-design/npm-publish
|
||||||
and must not be reused for the corrected platform/workloads/coulomb/whynot-design/npm-publish
|
and must not be reused for the corrected platform/workloads/coulomb/whynot-design/npm-publish
|
||||||
scope.
|
scope.
|
||||||
|
- at: '2026-06-27T23:23:19+00:00'
|
||||||
|
reviewer: human
|
||||||
|
decision: approved
|
||||||
|
comment: 'State Hub decision e6381a56-6b04-4fd5-b2de-f3ef59cde888: APPROVE: We
|
||||||
|
fixed the path using coulomb as the org/tenant.'
|
||||||
target:
|
target:
|
||||||
domain: financials
|
domain: financials
|
||||||
tenant: coulomb
|
tenant: coulomb
|
||||||
|
|
@ -103,3 +108,4 @@ state_hub:
|
||||||
decision_id: e6381a56-6b04-4fd5-b2de-f3ef59cde888
|
decision_id: e6381a56-6b04-4fd5-b2de-f3ef59cde888
|
||||||
decision_api_url: http://127.0.0.1:8000/decisions/e6381a56-6b04-4fd5-b2de-f3ef59cde888
|
decision_api_url: http://127.0.0.1:8000/decisions/e6381a56-6b04-4fd5-b2de-f3ef59cde888
|
||||||
decision_dashboard_url: http://127.0.0.1:3000/decisions
|
decision_dashboard_url: http://127.0.0.1:3000/decisions
|
||||||
|
decision_resolved_at: '2026-06-27T23:16:21.905924Z'
|
||||||
|
|
|
||||||
|
|
@ -58,18 +58,18 @@ class CredentialChangeTests(unittest.TestCase):
|
||||||
def test_status_payload_marks_template_not_resolvable(self) -> None:
|
def test_status_payload_marks_template_not_resolvable(self) -> None:
|
||||||
ccr, _errors, warnings = credential_change.validate_ccr(self.sample)
|
ccr, _errors, warnings = credential_change.validate_ccr(self.sample)
|
||||||
payload = credential_change.status_payload(ccr, warnings)
|
payload = credential_change.status_payload(ccr, warnings)
|
||||||
self.assertFalse(payload["apply_allowed"])
|
self.assertTrue(payload["apply_allowed"])
|
||||||
self.assertFalse(payload["frontdoor_resolvable"])
|
self.assertFalse(payload["frontdoor_resolvable"])
|
||||||
self.assertEqual(payload["access_frontdoor"]["readiness"], "template")
|
self.assertEqual(payload["access_frontdoor"]["readiness"], "template")
|
||||||
self.assertEqual(payload["access_frontdoor"]["catalog_id"], "whynot-design-npm-publish")
|
self.assertEqual(payload["access_frontdoor"]["catalog_id"], "whynot-design-npm-publish")
|
||||||
self.assertEqual(payload["apply_blockers"], ["apply requires status approved, got proposed"])
|
self.assertEqual(payload["apply_blockers"], [])
|
||||||
self.assertEqual(payload["warnings"], [])
|
self.assertEqual(payload["warnings"], [])
|
||||||
self.assertEqual(
|
self.assertEqual(
|
||||||
payload["state_hub"]["decision_id"],
|
payload["state_hub"]["decision_id"],
|
||||||
"e6381a56-6b04-4fd5-b2de-f3ef59cde888",
|
"e6381a56-6b04-4fd5-b2de-f3ef59cde888",
|
||||||
)
|
)
|
||||||
self.assertIn(
|
self.assertIn(
|
||||||
"front door requires CCR status active, got proposed",
|
"front door requires CCR status active, got approved",
|
||||||
payload["frontdoor_blockers"],
|
payload["frontdoor_blockers"],
|
||||||
)
|
)
|
||||||
self.assertIn("front door is marked resolvable=false", payload["frontdoor_blockers"])
|
self.assertIn("front door is marked resolvable=false", payload["frontdoor_blockers"])
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue