auth-role-presence-watch: dry-run policy_write carries source and body; approve state-hub summary tolerates non-KV CCRs
All checks were successful
CCR intake gate / gate (push) Successful in 2m13s
CI Smoke / host-smoke (push) Successful in 1s
CI Smoke / container-smoke (push) Successful in 2s

The founder's applier-dry-run of CCR-2026-0064 crashed (KeyError 'source') in render_applier_dry_run.
New test renders the dry run and the apply plan through the CLI. The --record-state-hub summary of
approve no longer assumes openbao.fields, which lane CCRs without a KV path do not have.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Assistant: claude-code
Assistant-Model: opus
Assistant-Process: 943911@bnt-lap001
Assistant-Session: fc322940-1c8e-4bed-ab39-86cec99f23a0
This commit is contained in:
codex 2026-11-06 10:20:04 +01:00
parent b1421317e7
commit 69530053ab
3 changed files with 17 additions and 4 deletions

View file

@ -137,8 +137,7 @@ def dry_run_payload(ccr: dict[str, Any], repo_dir: Path, warnings: list[str]) ->
"source_artifacts": {"policy_file": openbao["policy_file"]},
"mutations": [
{"kind": "policy_write", "openbao_path": f"sys/policies/acl/{openbao['policy_name']}",
"payload": {"source": openbao["policy_file"], "watched_path": watched_path(ccr),
"capabilities": MODES[openbao["watch"]["mode"]]}},
"source": openbao["policy_file"], "body": generated_policy_hcl(ccr)},
{"kind": "auth_role_write", "openbao_path": f"auth/{auth['mount']}/role/{auth['role']}",
"payload": role_payload(ccr), "precondition": "auth/kubernetes exists (never enabled here)"},
{"kind": "readback_compare", "openbao_path": "policy and role", "payload": {"prints": "booleans only"}},

View file

@ -2304,7 +2304,7 @@ def command_decision(args: argparse.Namespace, status: str) -> int:
"summary": (
f"CCR {ccr['id']} decision {status} by {args.reviewer}: "
f"path={openbao.get('kv_path', '-')} policy={openbao['policy_name']} "
f"fields={','.join(openbao['fields'])} "
f"fields={','.join(openbao.get('fields') or []) or '-'} "
f"auth_role=auth/{auth['mount']}/role/{auth['role']}; "
f"{args.comment}"
),

View file

@ -61,13 +61,27 @@ class AuthRoleWatchLaneTests(unittest.TestCase):
def test_ccr_validates_and_blocks_until_approved_and_bound(self):
_ccr, errors, _w = cc.validate_ccr(CCR_PATH)
self.assertEqual(errors, [])
blockers = cc.applier_readiness_blockers(_ccr)
draft = copy.deepcopy(_ccr) # independent of the file's live review state
draft.update(status="proposed")
draft["openbao"]["auth"]["bound_claims_confirmed"] = False
blockers = cc.applier_readiness_blockers(draft)
self.assertIn("applier requires confirmed OpenBao auth binding", blockers)
ready = copy.deepcopy(_ccr)
ready["status"] = "approved"
ready["openbao"]["auth"]["bound_claims_confirmed"] = True
self.assertEqual(cc.applier_readiness_blockers(ready), [])
def test_dry_run_and_apply_plan_render_through_the_cli(self):
"""2026-11-06: the founder's dry run crashed on a policy_write without source and body."""
ready = copy.deepcopy(ccr())
ready.update(status="approved")
ready["openbao"]["auth"]["bound_claims_confirmed"] = True
dry = cc.render_applier_dry_run(cc.applier_dry_run_payload(ready, []))
self.assertIn("policy_write: sys/policies/acl/net-kingdom-bounded-executor-window-watch", dry)
self.assertIn('path "%s" {' % WATCHED, dry)
self.assertIn("auth_role_write: auth/kubernetes/role/net-kingdom-bounded-executor-window-watch", dry)
self.assertIn("CCR-2026-0064", cc.render_applier_apply_plan(ready, []))
def test_flag_policy_is_one_read_and_self_lifecycle(self):
text = (ROOT / ccr()["openbao"]["policy_file"]).read_text()
paths = [line.split('"')[1] for line in text.splitlines() if line.startswith("path ")]