Add lighthouse showcase pack (v0.1 runnable, v0.2 draft); fix manual-check cycle and blocked-step feedback (RBT-WP-0004-T05)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Assistant: claude-code
Assistant-Model: sonnet
Assistant-Process: 295952@bnt-lap001
Assistant-Session: e93f64ad-516c-46eb-9666-aad8d300c477

tests/test_showcase.py

@@ -0,0 +1,69 @@
+from pathlib import Path
+import shutil
+import subprocess
+
+import pytest
+import yaml
+
+from rtut import pack as P, run as R
+
+ROOT = Path(__file__).resolve().parent.parent
+SRC = ROOT / "runbooks/showcase-lighthouse"
+
+
+@pytest.fixture
+def pk(tmp_path):
+    d = tmp_path / "runbooks" / "showcase"; d.mkdir(parents=True)
+    shutil.copy(SRC / "pack.yaml", d / "pack.yaml")
+    return P.load(d / "pack.yaml")
+
+
+def test_showcase_is_valid():
+    assert P.load(SRC / "pack.yaml").ok
+
+
+def test_v02_draft_is_wellformed_and_self_consistent():
+    d = yaml.safe_load((SRC / "pack.v0.2.draft.yaml").read_text())
+    assert d["spec"] == "runbook-pack/v0.2"
+    actors = {a["id"] for a in d["actors"]}
+    dps = {x["id"] for x in d["datapoints"]}
+    steps = {}
+    for st in d["stages"]:
+        for s in st["steps"]:
+            steps[s["id"]] = s
+            assert s["actor"] in actors
+            for u in s.get("uses", []):
+                assert u in dps, u
+    gates = {g["id"] for st in d["stages"] for g in st.get("gates", [])}
+    stages = {st["id"] for st in d["stages"]}
+    for st in d["stages"]:
+        for r in st.get("requires", []):
+            assert r.removeprefix("gate:") in gates | stages
+    assert any(s.get("reversible") is False for s in steps.values())
+    assert any("one_of" in s for s in steps.values())
+    assert not any(k.startswith("secret") for x in d["datapoints"] for k in x)
+
+
+def test_scripted_playthrough(pk):
+    r = R.create(pk, "tester", {"keeper": "Ada", "weather": "storm", "motto": "Light on"})
+    for s in pk.data["steps"]:
+        sid = s["id"]
+        R.start(r, sid)
+        cmd = R.command_for(r, sid)          # the operator runs the command...
+        if cmd:
+            subprocess.run(cmd, shell=True, check=True, capture_output=True)
+        v = s["verify"]                     # ...then the engine verifies the result
+        res = R.verify(r, sid, confirm=True, manual_ok=True if v["expect"] == "manual" else None)
+        assert res["passed"], sid
+        R.complete(r, sid, {n: "1" for n in s.get("evidence", [])})
+    assert r.complete
+    assert not Path(r.data["params"]["logdir"]).exists()
+    old, new = R.exercise_update(r)
+    assert "exercised" in new
+
+
+def test_bad_logdir_rejected(pk):
+    with pytest.raises(R.RunError):
+        R.create(pk, "tester", {"logdir": "/etc"})
+    with pytest.raises(R.RunError):
+        R.create(pk, "tester", {"motto": 'x"; rm -rf /'})

tests/test_ui.py

@@ -66,3 +66,31 @@ def test_secret_in_note_refused(srv):
     req(srv, "POST", loc + "/ping/start", {"_t": t})
     st, _, body = req(srv, "POST", loc + "/ping/fail", {"_t": t, "note": "hvs.ABCDEFGHIJKLMN"})
     assert st == 400 and "secret-looking" in body
+
+
+def test_manual_check_cycle_and_blocked_reason(srv):
+    """Yes/Not-yet buttons, 'Mark done' to lock in, numbering, and why later steps are blocked."""
+    import shutil
+    t = srv.app.token
+    # use the showcase pack, which starts with a manual step
+    d = Path(srv.app.packs[0].path).parents[2] / "runbooks" / "show"; d.mkdir(parents=True)
+    shutil.copy(ROOT / "runbooks/showcase-lighthouse/pack.yaml", d / "pack.yaml")
+    from rtut import pack as P
+    srv.app.packs.append(P.load(d / "pack.yaml"))
+    i = len(srv.app.packs) - 1
+    _, loc, _ = req(srv, "POST", f"/run/new/{i}", {"_t": t, "operator": "bernd"})
+    _, _, body = req(srv, "GET", loc)
+    assert "0 of 8 steps done" in body and "1. Read the poem" in body
+    assert "Waiting for: step 1" in body                      # blocked steps explain themselves
+    req(srv, "POST", loc + "/read-the-sign/start", {"_t": t})
+    _, _, body = req(srv, "GET", loc)
+    assert "Yes, it is" in body and "Not yet" in body and "/read-the-sign/done" not in body
+    req(srv, "POST", loc + "/read-the-sign/verify", {"_t": t, "ok": "0"})
+    _, _, body = req(srv, "GET", loc)
+    assert "Check not passed" in body and "/read-the-sign/done" not in body
+    req(srv, "POST", loc + "/read-the-sign/verify", {"_t": t, "ok": "1"})
+    _, _, body = req(srv, "GET", loc)
+    assert "Check passed" in body and "/read-the-sign/done" in body
+    req(srv, "POST", loc + "/read-the-sign/done", {"_t": t})
+    _, _, body = req(srv, "GET", loc)
+    assert "1 of 8 steps done" in body and "Start this step" in body