Projects have their own name, description and goal; the template is shown only as origin

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Assistant: claude-code
Assistant-Model: sonnet
Assistant-Process: 295952@bnt-lap001
Assistant-Session: e93f64ad-516c-46eb-9666-aad8d300c477

tests/test_projects.py

@@ -197,10 +197,13 @@ def test_runs_of_other_projects_do_not_count(repo):
 
 def test_instantiate_template_records_origin_merges_values_and_lists_needs(repo):
     reg = Registry([repo])
-    out = J.instantiate(reg, "lighthouse-watch", "harbour-north", "rehearsal", {"keeper": "Ada", "logdir": "/tmp/rtut-harbour"})
+    out = J.instantiate(reg, "lighthouse-watch", "harbour-north", "rehearsal", {"keeper": "Ada", "logdir": "/tmp/rtut-harbour"},
+                        title="North harbour watch", description="Our own harbour", goal="Both lights keep watch")
     made = yaml.safe_load(out.read_text())
     assert made["spec"] == "project/v0.1" and made["template"] == "lighthouse-watch" and made["environment"] == "rehearsal"
-    assert made["attributes"]["keeper"] == "Ada" and made["goal"].startswith("The night watch")
+    assert made["attributes"]["keeper"] == "Ada"
+    assert made["title"] == "North harbour watch" and made["description"] == "Our own harbour" and made["goal"] == "Both lights keep watch"
+    assert "The night watch is played through" not in out.read_text() and "A watch at a lighthouse" not in out.read_text()   # nothing of the template's text is copied
     assert set(made["targets"]) == {"north-light", "south-light"}
     reg = Registry([repo])
     assert reg.projects["harbour-north"].ok and J.validate(reg, reg.projects["harbour-north"]) == []
@@ -235,3 +238,14 @@ def test_set_attributes_validates_against_the_consuming_runbooks(repo):
 def test_attribute_notes_survive_resolution(repo):
     reg = Registry([repo])
     assert "Who keeps this light" in fold(set_layers(reg, "harbour-defaults"))["keeper"]["note"]
+
+
+def test_project_without_a_given_name_uses_its_id_never_the_templates_title(repo):
+    reg = Registry([repo])
+    out = J.instantiate(reg, "lighthouse-watch", "plain-one", "staging")
+    made = yaml.safe_load(out.read_text())
+    assert made["title"] == "plain-one" and "goal" not in made and "description" not in made
+    with pytest.raises(ValueError, match="3 characters"):
+        J.instantiate(reg, "lighthouse-watch", "ab", "staging")
+    with pytest.raises(ValueError, match="secret"):
+        J.instantiate(reg, "lighthouse-watch", "leaky-one", "staging", description="token hvs.ABCDEFGHIJKLMN")

tests/test_ui_projects.py

@@ -50,7 +50,8 @@ def req(s, method, path, form=None, host="127.0.0.1"):
 
 def make_project(s, pid="harbour", host=None):
     t = s.app.token
-    form = {"_t": t, "project_id": pid, "environment": "rehearsal", "a_keeper": "Ada", "a_logdir": f"/tmp/rtut-ui-{pid}"}
+    form = {"_t": t, "project_id": pid, "environment": "rehearsal", "a_keeper": "Ada", "a_logdir": f"/tmp/rtut-ui-{pid}",
+            "title": "Harbour watch", "description": "Our own harbour, two lights.", "goal": "Both lights keep watch tonight"}
     if host:
         form["a_host"] = host
     return req(s, "POST", "/template/lighthouse-watch/new", form)
@@ -68,6 +69,7 @@ def test_template_page_shows_attributes_with_requirement_and_notes(psrv):
     assert st == 200 and "A watch at a lighthouse" in body
     assert "name='a_keeper'" in body and "Who keeps this light" in body and ">required<" in body
     assert "name='a_weather'" not in body                       # weather is set per target, so it is not a template question
+    assert "name=title" in body and "name=description" in body and "name=goal" in body          # the project's own identity
     assert "Create project" in body and "<option>rehearsal</option>" in body and "<option>production</option>" in body
     assert req(psrv, "GET", "/template/nope")[0] == 404
 
@@ -78,9 +80,11 @@ def test_create_project_from_template_and_view_it(psrv):
     made = yaml.safe_load((psrv.repo / "projects/harbour/project.yaml").read_text())
     assert made["template"] == "lighthouse-watch" and made["environment"] == "rehearsal" and made["attributes"]["keeper"] == "Ada"
     _, _, body = req(psrv, "GET", "/project/harbour")
-    assert "A watch at a lighthouse" in body and "from template lighthouse-watch" in body
+    assert "<h1>Harbour watch</h1>" in body and "Our own harbour, two lights." in body and "Both lights keep watch tonight" in body
+    assert "from template <a href='/template/lighthouse-watch'>lighthouse-watch</a>" in body        # origin is shown, as a link
+    assert "A watch at a lighthouse" not in body                                                     # the template's title...
+    assert "The night watch is played through" not in body                                           # ...and its description are not
     assert ">planned<" in body and ">rehearsal<" in body
-    assert "The night watch is played through" in body                # the goal
     assert "target:north-light" in body                                # provenance of the fog weather
     assert "Still needed" in body and "name='a_host'" in body         # hello needs a host
     assert "cannot be run in this UI yet" in body                     # the v0.2 member
@@ -159,12 +163,12 @@ def test_csrf_host_and_escaping(psrv):
 
 def test_bad_project_id_and_duplicate_are_refused(psrv):
     t = psrv.app.token
-    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "project_id": "Bad Id!", "environment": "rehearsal"})
+    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "title": "Some name", "project_id": "Bad Id!", "environment": "rehearsal"})
     assert st == 400 and "project id" in body
     assert make_project(psrv)[0] == 303
-    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "project_id": "harbour", "environment": "rehearsal"})
+    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "title": "Some name", "project_id": "harbour", "environment": "rehearsal"})
     assert st == 400 and "already exists" in body
-    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "project_id": "other", "environment": "prod"})
+    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "title": "Some name", "project_id": "other", "environment": "prod"})
     assert st == 400 and "environment" in body
 
 
@@ -175,3 +179,20 @@ def test_v02_run_shows_a_guard_instead_of_crashing(psrv):
     i = psrv.app.pack_index("rtut.showcase-lighthouse-v2")
     st, _, body = req(psrv, "GET", f"/run/{i}/{r.data['run_id']}")
     assert st == 200 and "cannot walk v0.2 runs yet" in body
+
+
+def test_front_page_lists_projects_by_their_own_name_and_shows_the_template_as_origin(psrv):
+    make_project(psrv)
+    _, _, body = req(psrv, "GET", "/")
+    projects = body.split("<h2>Project templates</h2>")[0]
+    assert "Harbour watch" in projects and "Our own harbour, two lights." in projects
+    assert "from template <a href='/template/lighthouse-watch'>lighthouse-watch</a>" in projects
+    assert "The night watch is played through" not in projects and "A watch at a lighthouse" not in projects
+    assert "A watch at a lighthouse" in body.split("<h2>Project templates</h2>")[1]               # the template keeps its own listing
+
+
+def test_creating_a_project_needs_a_name(psrv):
+    t = psrv.app.token
+    st, _, body = req(psrv, "POST", "/template/lighthouse-watch/new", {"_t": t, "project_id": "nameless", "environment": "rehearsal", "title": "x"})
+    assert st == 400 and "name" in body
+    assert not (psrv.repo / "projects/nameless").exists()