feat: admit existing OpenBao catalog lanes
All checks were successful
CI Smoke / host-smoke (push) Successful in 0s
CI Smoke / container-smoke (push) Successful in 2s

This commit is contained in:
tegwick 2026-08-21 08:20:33 +02:00
parent 9d383442c8
commit 784be978bf
29 changed files with 1490 additions and 79 deletions

View file

@ -74,6 +74,86 @@ def test_unknown_delivery_mode_rejected():
validate_entry(data)
def test_existing_mount_and_workload_delivery_parse():
data = copy.deepcopy(VALID)
data["mount"] = "platform"
data["mount_management"] = "existing"
data["workload_delivery"] = [
{"mode": "external-secrets", "owner": "rapp-example"}
]
entry = validate_entry(data)
assert entry.manages_mount is False
assert entry.manages_delivery_auth is True
assert entry.workload_delivery[0]["mode"] == "external-secrets"
def test_existing_delivery_auth_requires_explicit_role():
data = copy.deepcopy(VALID)
data["delivery_auth"] = {"method": "approle", "management": "existing"}
with pytest.raises(CatalogError):
validate_entry(data)
data["delivery_auth"]["role_name"] = "existing-exact-role"
entry = validate_entry(data)
assert entry.manages_delivery_auth is False
assert entry.role_name == "existing-exact-role"
def test_native_delivery_rejects_missing_auth():
data = copy.deepcopy(VALID)
data["delivery_auth"] = {"method": "none", "management": "none"}
with pytest.raises(CatalogError):
validate_entry(data)
def test_workload_delivery_requires_mode_and_owner():
data = copy.deepcopy(VALID)
data["workload_delivery"] = [{"mode": "external-secrets"}]
with pytest.raises(CatalogError):
validate_entry(data)
def test_high_risk_lane_requires_owners_and_non_bootstrap_approval():
data = copy.deepcopy(VALID)
data["risk"] = {"classification": "high"}
data["approval"] = {"model": "decision", "decision_ref": "d1"}
with pytest.raises(CatalogError):
validate_entry(data)
data["rotation"]["owner"] = "platform-owner"
data["deactivation"]["owner"] = "platform-owner"
assert validate_entry(data).risk["classification"] == "high"
data["approval"] = {"model": "bootstrap-only"}
with pytest.raises(CatalogError):
validate_entry(data)
def test_admitted_existing_lanes_have_exact_safe_metadata():
entries = load_catalog(repo_root() / "catalog")
expected = {
"issue-core-ingestion-api-key": "workloads/issue-core/issue-core/issue-core-runtime",
"reuse-surface-hub-write-token": "workloads/reuse/reuse-surface/runtime-secrets",
"openrouter-llm-connect": "workloads/activity-core/llm-connect/llm-connect-provider-secrets",
"forgejo-admin-api-token": "workloads/forgejo/forgejo-admin",
"email-connect-transactional": "workloads/email-connect/transactional",
}
for lane_id, path in expected.items():
entry = entries[lane_id]
assert entry.mount == "platform"
assert entry.path == path
assert entry.manages_mount is False
assert entry.manages_delivery_auth is True
assert entry.risk["classification"] == "high"
assert entry.rotation["owner"]
assert entry.deactivation["owner"]
assert entry.workload_delivery
assert entry.approval["decision_ref"].startswith("CCR-2026-")
def test_generic_and_identity_routes_are_not_catalog_lanes():
entries = load_catalog(repo_root() / "catalog")
assert "openbao-api-key" not in entries
assert "key-cape-oidc-login" not in entries
def test_wildcard_path_rejected():
data = copy.deepcopy(VALID)
data["path"] = "test/*"