feat: split the validator by owning layer per GH-DEC-2026-005
gate-house resolved APPROVAL-IN-0002. Two changes fell to this repo.
1. Split validate_action_authorization. The claim from approval-engine now
carries the approval fact (issuer, valid_now, consumption, binding digest,
freshness, reason_code) via approval_claim.validate_approval_claim; the
flex-auth DecisionEnvelope carries the decision (effect, binding match,
request digest, lifetime, policy pin) via validate_decision_envelope.
ActionAuthorization is deferred and never ratified (FLEX-DEC-2026-006) and
cannot be served from a step-1 call; nothing validates it now.
2. Dropped AUTHORITY = "state-hub" and the provenance.authority requirement.
State Hub is a read model with no runtime approval authority, so the check
failed closed against every correctly issued record. flex-auth traced the
constant to their own fixture and fixed it at source.
Two consequences recorded rather than buried: there are now two distinct
digests over the same action (approval-engine native over
{action,actor,principal,purpose,target}, and the flex-auth CheckRequest
digest) which are never compared to each other; and the distinct-approver
threshold is no longer checked here, since the claim exposes no approver
entries and approval-engine folds it into valid_now.
The canonical request digest is unchanged and its contract test is preserved
verbatim. Production still fails closed. 251 tests pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M65ovP3eiiPHubibvWs9mD
Assistant: claude-code
Assistant-Model: opus
Assistant-Process: 393550@bnt-lap001
Assistant-Session: 4bb359f9-1f12-4410-9e76-079cf23c82e4
This commit is contained in:
parent
dbd3694f71
commit
7b4b9e386e
8 changed files with 694 additions and 325 deletions
|
|
@ -13,11 +13,14 @@ from pathlib import Path
|
|||
|
||||
import pytest
|
||||
|
||||
from secrets_engine.approval_claim import (
|
||||
binding_from_check_request,
|
||||
claim_binding_digest,
|
||||
)
|
||||
from secrets_engine.approval_consume import resolve_consume_binding
|
||||
from secrets_engine.authorization import build_action_request, request_digest
|
||||
from secrets_engine.catalog import validate_entry
|
||||
from secrets_engine.errors import DecisionError
|
||||
from tests.test_action_authorization import _envelope
|
||||
from tests.test_catalog import VALID
|
||||
|
||||
AUTH_ID = "8bfc20be-47a4-4fb0-97a2-bf0a920afad8"
|
||||
|
|
@ -51,19 +54,43 @@ def _token(tmp_path):
|
|||
return f
|
||||
|
||||
|
||||
def _served(**over):
|
||||
"""A served envelope whose validity window is live now."""
|
||||
env = copy.deepcopy(_envelope())
|
||||
def _expected_request(entry, action="deactivate", fields=("api_token",)):
|
||||
return build_action_request(
|
||||
entry, action,
|
||||
subject_id="user:alice", subject_type="Human", purpose="contract-test",
|
||||
fields=list(fields),
|
||||
policy_targets=[entry.policy_name], auth_targets=[entry.role_name],
|
||||
)
|
||||
|
||||
|
||||
def _served(entry=None, action="deactivate", fields=("api_token",), **over):
|
||||
"""An approval-engine approval-claim bound to the proposed action."""
|
||||
entry = entry or _entry()
|
||||
request = _expected_request(entry, action, fields)
|
||||
binding = binding_from_check_request(request)
|
||||
now = datetime.now(timezone.utc)
|
||||
env["validity"] = {
|
||||
"not_before": (now - timedelta(minutes=5)).strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
"expires_at": (now + timedelta(minutes=10)).strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
claim = {
|
||||
"schema_version": "0.1",
|
||||
"kind": "approval-claim",
|
||||
"issuer": "approval-engine",
|
||||
"approval_id": AUTH_ID,
|
||||
"state": "valid",
|
||||
"valid_now": True,
|
||||
"consumed": False,
|
||||
"binding": {**binding, "digest": claim_binding_digest(**binding)},
|
||||
"freshness": {
|
||||
"observed_at": now.strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
"ttl_seconds": 30,
|
||||
"not_after": (now + timedelta(seconds=30)).strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
},
|
||||
"validity": {
|
||||
"not_before": (now - timedelta(minutes=5)).strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
"expires_at": (now + timedelta(minutes=10)).strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
},
|
||||
"reason_code": "ok",
|
||||
}
|
||||
approved = (now - timedelta(minutes=4)).strftime("%Y-%m-%dT%H:%M:%SZ")
|
||||
for approval in env["approvals"]["entries"]:
|
||||
approval["approved_at"] = approved
|
||||
env.update(over)
|
||||
return env
|
||||
claim.update(over)
|
||||
return claim
|
||||
|
||||
|
||||
def _opener(envelope, status=200):
|
||||
|
|
@ -99,14 +126,7 @@ def test_valid_authorization_yields_binding_with_canonical_digest(tmp_path):
|
|||
binding = _resolve(cfg, entry, _served())
|
||||
assert binding is not None
|
||||
assert binding.approval_id == AUTH_ID
|
||||
expected = build_action_request(
|
||||
entry, "deactivate",
|
||||
subject_id="user:alice", subject_type="Human", purpose="contract-test",
|
||||
fields=["api_token"],
|
||||
policy_targets=[entry.policy_name], auth_targets=[entry.role_name],
|
||||
request_id="check:test-lane-deactivate",
|
||||
)
|
||||
assert binding.request_digest == request_digest(expected)
|
||||
assert binding.request_digest == request_digest(_expected_request(entry))
|
||||
|
||||
|
||||
def test_missing_subject_raises_instead_of_returning_none(tmp_path):
|
||||
|
|
@ -116,11 +136,12 @@ def test_missing_subject_raises_instead_of_returning_none(tmp_path):
|
|||
_resolve(cfg, _entry(), _served())
|
||||
|
||||
|
||||
def test_example_policy_names_are_not_an_implicit_pin(tmp_path):
|
||||
def test_policy_pin_is_not_enforced_on_the_claim_path(tmp_path):
|
||||
"""flex-auth: the published example vocabulary is not a live pin."""
|
||||
# The pin is a step-2 (DecisionEnvelope) concern after GH-DEC-2026-005 and
|
||||
# is asserted in tests/test_action_authorization.py, not on the claim path.
|
||||
cfg = _Cfg(_token(tmp_path), authorization_policy_package="")
|
||||
with pytest.raises(DecisionError, match="policy .*pin"):
|
||||
_resolve(cfg, _entry(), _served())
|
||||
assert _resolve(cfg, _entry(), _served()) is not None
|
||||
|
||||
|
||||
def test_wrong_field_set_fails_closed(tmp_path):
|
||||
|
|
@ -158,6 +179,6 @@ def test_unreachable_approval_engine_fails_closed(tmp_path):
|
|||
)
|
||||
|
||||
|
||||
def test_superseded_authorization_fails_closed(tmp_path):
|
||||
def test_superseded_claim_fails_closed(tmp_path):
|
||||
with pytest.raises(DecisionError):
|
||||
_resolve(_Cfg(_token(tmp_path)), _entry(), _served(status="superseded"))
|
||||
_resolve(_Cfg(_token(tmp_path)), _entry(), _served(valid_now=False, reason_code="superseded"))
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue