tegwick
f87f4e5e4d
Gitea's "project/package/release" terms are overloaded, so the catalog now uses the most explicit words: - org = coulomb (the Gitea organisation) - repo = whynot-design (the Gitea repository/product) — not an org, not a scope - npm scope @whynot and package @whynot/design are distinct from both Changes: - catalog schema: replace conflated `owner` with required `org` + `repo`; `owner` is now a derived `org/repo` slug property - npm-config delivery is data-driven: registry + scope live in delivery_config.npm and are validated; engine no longer hardcodes a registry - exec delivery writes `<scope>:registry=<url>` + scoped `:_authToken` for the configured Gitea registry (token still env-expanded, never written to disk) - pilot lane points at https://gitea.coulomb.social/api/packages/coulomb/npm/, scope @whynot, KV path coulomb/whynot-design/npm/publish - npm-publish-demo uses @whynot scope so dry-run resolves the Gitea registry - docs: terminology table; routing owner shown as coulomb/whynot-design - tests: org/repo required, npm-config validation, registry authkey mapping Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
103 lines
3.1 KiB
Python
103 lines
3.1 KiB
Python
import copy
|
|
|
|
import pytest
|
|
|
|
from secrets_engine.catalog import validate_entry, load_catalog
|
|
from secrets_engine.config import repo_root
|
|
from secrets_engine.errors import CatalogError
|
|
|
|
VALID = {
|
|
"id": "test-lane",
|
|
"org": "coulomb",
|
|
"repo": "team-repo",
|
|
"stage": "test",
|
|
"mount": "secret",
|
|
"path": "test/team/thing",
|
|
"fields": ["api_token"],
|
|
"consumers": [{"name": "c", "auth": "approle", "claim": "role:c"}],
|
|
"delivery_modes": ["exec-env"],
|
|
"approval": {"model": "bootstrap-only"},
|
|
"verification": {"positive": "x", "negative": "y"},
|
|
"rotation": {"ttl": "1h"},
|
|
"deactivation": {"expectation": "delete"},
|
|
"audit": {"evidence": "non-secret"},
|
|
}
|
|
|
|
|
|
def test_valid_entry_parses():
|
|
e = validate_entry(VALID)
|
|
assert e.id == "test-lane"
|
|
assert e.policy_name == "se-test-test-lane"
|
|
assert not e.approval_required()
|
|
# owner is the explicit org/repo slug, not a bare name
|
|
assert e.owner == "coulomb/team-repo"
|
|
|
|
|
|
@pytest.mark.parametrize("field", ["org", "repo"])
|
|
def test_missing_org_or_repo_rejected(field):
|
|
data = copy.deepcopy(VALID)
|
|
data.pop(field)
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data)
|
|
|
|
|
|
def test_npm_config_requires_registry_and_scope():
|
|
data = copy.deepcopy(VALID)
|
|
data["delivery_modes"] = ["npm-config"]
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data) # no delivery_config.npm
|
|
data["delivery_config"] = {"npm": {"registry": "https://x/", "scope": "@s"}}
|
|
e = validate_entry(data)
|
|
assert e.npm["scope"] == "@s"
|
|
|
|
|
|
@pytest.mark.parametrize("field", ["stage", "mount", "path", "fields", "approval", "delivery_modes"])
|
|
def test_missing_required_field_rejected(field):
|
|
data = copy.deepcopy(VALID)
|
|
data.pop(field)
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data)
|
|
|
|
|
|
def test_bad_stage_rejected():
|
|
data = copy.deepcopy(VALID)
|
|
data["stage"] = "staging"
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data)
|
|
|
|
|
|
def test_unknown_delivery_mode_rejected():
|
|
data = copy.deepcopy(VALID)
|
|
data["delivery_modes"] = ["telepathy"]
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data)
|
|
|
|
|
|
def test_wildcard_path_rejected():
|
|
data = copy.deepcopy(VALID)
|
|
data["path"] = "test/*"
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data)
|
|
|
|
|
|
def test_inline_secret_value_rejected():
|
|
data = copy.deepcopy(VALID)
|
|
data["token"] = "npm_realvalue"
|
|
with pytest.raises(CatalogError):
|
|
validate_entry(data)
|
|
|
|
|
|
def test_repo_catalog_loads_and_has_pilot():
|
|
entries = load_catalog(repo_root() / "catalog")
|
|
assert "whynot-design-npm-publish" in entries
|
|
pilot = entries["whynot-design-npm-publish"]
|
|
assert pilot.stage == "prod"
|
|
assert pilot.approval_required()
|
|
# org=coulomb, repo=whynot-design (not conflated); npm targets Gitea registry
|
|
assert pilot.org == "coulomb"
|
|
assert pilot.repo == "whynot-design"
|
|
assert pilot.npm["registry"].startswith("https://gitea.coulomb.social/")
|
|
assert pilot.npm["scope"] == "@whynot"
|
|
# build/test/prod stage separation is representable
|
|
stages = {e.stage for e in entries.values()}
|
|
assert {"build", "prod"} <= stages
|