coulomb/state-hub
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CUST-WP-0074-T02: task wait qualifiers in the hub read model

Browse source 
Adds tasks.decision_id and workplan_dependencies.from_task_id (migration
e8f9a0b1c2d3). A from_task_id column is needed rather than
from_workplan_id plus description: the partial unique indexes key on
(from_workplan_id, target, relationship_type), so two tasks in one
workplan waiting on the same target could not both be indexed, and the
derived wait_kind needs per-task attribution. The two existing unique
indexes are narrowed to frontmatter edges (from_task_id IS NULL) and two
task-origin counterparts are added; downgrade deletes task-origin rows
before restoring the old indexes.

POST /workplans/{id}/dependencies/ accepts from_task_id (must belong to
the from workplan; a task cannot depend on itself). TaskCreate/Update/Read
carry decision_id.

Derived read-model fields, no new write routes (rule 5):
- TaskRead.wait_kind: external | human | both | unqualified, null unless
  status is wait (dependency rows from this task / needs_human).
- WorkplanRead.blocked_kind: human | external | none, null unless status
  is blocked. Human wins over external.
Both come from api/services/wait_kind.py, applied on GET /tasks/,
GET /tasks/{id}, GET /workplans/ and GET /workplans/{id}.

The identifier-migration reference-count proof now includes from_task_id
(FK count guard 22 -> 23).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Assistant: claude-code
Assistant-Model: sonnet
Assistant-Process: 237582@bnt-lap001
Assistant-Session: f2b3d9f1-8fb9-4b9c-bc2b-837ec5dfc826
This commit is contained in:
tegwick 2026-09-28 22:39:18 +02:00
parent e92471df3b
commit b9997d6fc7
13 changed files with 400 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

31
api/models/workplan_dependency.py
View file

@ -28,7 +28,7 @@ class WorkplanDependency(Base, TimestampMixin):
"to_workplan_id",
"relationship_type",
unique=True,
postgresql_where=text("to_workplan_id IS NOT NULL"),
postgresql_where=text("to_workplan_id IS NOT NULL AND from_task_id IS NULL"),
),
Index(
"uq_wp_dep_task_target",
@ -36,7 +36,25 @@ class WorkplanDependency(Base, TimestampMixin):
"to_task_id",
"relationship_type",
unique=True,
postgresql_where=text("to_task_id IS NOT NULL"),
postgresql_where=text("to_task_id IS NOT NULL AND from_task_id IS NULL"),
),
# Task-block `depends_on` edges (CUST-WP-0074): the waiting task is the
# from side, so two tasks in one workplan may wait on the same target.
Index(
"uq_wp_dep_from_task_workplan_target",
"from_task_id",
"to_workplan_id",
"relationship_type",
unique=True,
postgresql_where=text("to_workplan_id IS NOT NULL AND from_task_id IS NOT NULL"),
),
Index(
"uq_wp_dep_from_task_task_target",
"from_task_id",
"to_task_id",
"relationship_type",
unique=True,
postgresql_where=text("to_task_id IS NOT NULL AND from_task_id IS NOT NULL"),
),
)
@ -49,6 +67,14 @@ class WorkplanDependency(Base, TimestampMixin):
nullable=False,
index=True,
)
# Set when the edge originates from a task block rather than workplan
# frontmatter; always belongs to `from_workplan_id`.
from_task_id: Mapped[uuid.UUID | None] = mapped_column(
UUID(as_uuid=True),
ForeignKey("tasks.id", ondelete="CASCADE", onupdate="CASCADE"),
nullable=True,
index=True,
)
to_workplan_id: Mapped[uuid.UUID | None] = mapped_column(
UUID(as_uuid=True),
ForeignKey("workplans.id", ondelete="CASCADE", onupdate="CASCADE"),
@ -72,4 +98,5 @@ class WorkplanDependency(Base, TimestampMixin):
to_workplan: Mapped["Workplan | None"] = relationship( # noqa: F821
"Workplan", foreign_keys=[to_workplan_id]
)
from_task: Mapped["Task | None"] = relationship("Task", foreign_keys=[from_task_id]) # noqa: F821
to_task: Mapped["Task | None"] = relationship("Task", foreign_keys=[to_task_id]) # noqa: F821