coulomb/target-revenue
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Implement WP-0015-T01/T04/T06: Phase provenance schema + ledger UI

Browse source 
Schema: phase.milestone_release gains required repo_hub/repo_hub_uri/
repo_id/repo_name; phase gains optional base_phase_id. Backfilled the
golden phase-001 fixture (placeholder values, it's synthetic) and the
three real pilot-candidate manifests with actual Forgejo repo ids
confirmed live (net-kingdom=67, vergabe-teilnahme=62,
info-tech-canon=47, all coulomb/*).

Discovered along the way: the schema change alone would have broken
the existing Control Plane registration form, since nothing collected
the four new fields. Fixed inline rather than leaving it broken
between tasks -- this also completes T04's ledger UI change (drop the
hand-typed ledger input, auto-compute /phases/{id}/ledger, add a
drill-down reference link on phase_detail.html) since both changes
touch the same form/route.

Full suite: 94 passing offline (was 84), 158 passing with Docker
(was 146).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
tegwick 2026-08-03 20:43:30 +02:00
parent 11800c7da1
commit 2a176d9961
13 changed files with 204 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

29
tests/test_manifest_validation.py
View file

@ -59,3 +59,32 @@ def test_phase_id_immutable_across_versions():
def test_unchanged_manifest_has_no_immutability_violations():
manifest = golden_manifest()
assert validation.check_manifest_immutability(manifest, manifest) == []
@pytest.mark.parametrize(
"field", ["repo_hub", "repo_hub_uri", "repo_id", "repo_name"]
)
def test_manifest_missing_repo_provenance_field_is_rejected(field):
manifest = copy.deepcopy(golden_manifest())
del manifest["phase"]["milestone_release"][field]
with pytest.raises(validation.ConformanceError):
validation.validate_phase_manifest(manifest)
def test_manifest_with_absent_base_phase_id_is_conformant():
manifest = copy.deepcopy(golden_manifest())
assert "base_phase_id" not in manifest["phase"]
validation.validate_phase_manifest(manifest)
def test_manifest_with_present_base_phase_id_is_conformant():
manifest = copy.deepcopy(golden_manifest())
manifest["phase"]["base_phase_id"] = "trsl:phase:example-000"
validation.validate_phase_manifest(manifest)
def test_manifest_with_malformed_base_phase_id_is_rejected():
manifest = copy.deepcopy(golden_manifest())
manifest["phase"]["base_phase_id"] = "not-a-phase-id"
with pytest.raises(validation.ConformanceError):
validation.validate_phase_manifest(manifest)