TEN-WP-0002 T01-T03: service skeleton, domain model, storage layer

Python 3.12 + FastAPI, pyproject.toml + Makefile mirroring
qonto-assistant's exactly. src/tenant_engine/{domain,store,app,main}.py:

- domain.py: Tenant, CapabilityRole (PLTF/IAM/VEN/CUS), RoleGrant,
  PlanAssignment, create_role_grant() enforcing ADR-0014's invariants.
  Refinement made while implementing: platform_default grants are valid
  for trial-grouped tenants OR the reserved tenant:platform/tenant:coulomb
  tenants (their baseline roles were never purchased either) -- the task
  spec only named the trial case.
- store.py: TenantStore Protocol + InMemoryTenantStore, every mutation
  emits a DomainEvent per the boundary contract's Audit Correlation
  Contract.
- app.py/main.py: FastAPI factory + /health endpoint, verified live on
  127.0.0.1:8090.

29 tests passing, including non-exclusive role coexistence (CUS+VEN
simultaneously) and append-only revoke semantics.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
tegwick 2026-07-23 22:01:23 +02:00
parent 7eb21c05b8
commit 0770ce82d9
11 changed files with 774 additions and 3 deletions

13
tests/test_app.py Normal file
View file

@ -0,0 +1,13 @@
from fastapi.testclient import TestClient
from tenant_engine.app import create_app
def test_health_endpoint() -> None:
client = TestClient(create_app())
response = client.get("/health")
assert response.status_code == 200
body = response.json()
assert body["status"] == "ok"
assert body["service"] == "tenant-engine"

206
tests/test_domain.py Normal file
View file

@ -0,0 +1,206 @@
from datetime import UTC, datetime
import pytest
from tenant_engine.domain import (
CapabilityRole,
InvalidGrantError,
InvalidTenantIdentifierError,
Tenant,
create_role_grant,
parse_tenant_identifier,
)
def test_parse_tenant_identifier_reserved_platform() -> None:
grouping, name = parse_tenant_identifier("tenant:platform")
assert grouping is None
assert name == "platform"
def test_parse_tenant_identifier_reserved_coulomb() -> None:
grouping, name = parse_tenant_identifier("tenant:coulomb")
assert grouping is None
assert name == "coulomb"
def test_parse_tenant_identifier_grouped() -> None:
grouping, name = parse_tenant_identifier("tenant:friendly:binky")
assert grouping == "friendly"
assert name == "binky"
@pytest.mark.parametrize(
"identifier",
[
"tenant:unknown-grouping:binky",
"tenant:friendly",
"tenant:friendly:",
"not-a-tenant:friendly:binky",
"friendly:binky",
],
)
def test_parse_tenant_identifier_rejects_invalid_shapes(identifier: str) -> None:
with pytest.raises(InvalidTenantIdentifierError):
parse_tenant_identifier(identifier)
def test_tenant_create_from_identifier() -> None:
tenant = Tenant.create(tenant_id="t-1", identifier="tenant:friendly:binky")
assert tenant.grouping == "friendly"
assert tenant.is_reserved is False
def test_tenant_create_reserved_has_no_grouping() -> None:
tenant = Tenant.create(tenant_id="t-platform", identifier="tenant:platform")
assert tenant.grouping is None
assert tenant.is_reserved is True
def _tenant(*, grouping: str | None, identifier: str | None = None) -> Tenant:
if identifier is None:
identifier = f"tenant:{grouping}:acme" if grouping else "tenant:platform"
return Tenant.create(tenant_id="t-1", identifier=identifier)
def test_plan_assignment_grant_requires_plan_id() -> None:
tenant = _tenant(grouping="friendly")
with pytest.raises(InvalidGrantError):
create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.IAM,
grant_reason="plan_assignment",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
def test_plan_assignment_grant_with_plan_id_succeeds() -> None:
tenant = _tenant(grouping="friendly")
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.IAM,
grant_reason="plan_assignment",
plan_id="plan-iam-dedicated",
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
assert grant.active is True
assert grant.plan_id == "plan-iam-dedicated"
def test_platform_default_allowed_for_trial_tenant_without_plan() -> None:
tenant = _tenant(grouping="trial")
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.VEN,
grant_reason="platform_default",
plan_id=None,
granted_by="platform",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
assert grant.grant_reason == "platform_default"
assert grant.plan_id is None
def test_platform_default_allowed_for_reserved_tenant() -> None:
tenant = _tenant(grouping=None, identifier="tenant:platform")
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.PLTF,
grant_reason="platform_default",
plan_id=None,
granted_by="platform",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
assert grant.role is CapabilityRole.PLTF
def test_platform_default_rejected_for_non_trial_grouped_tenant() -> None:
tenant = _tenant(grouping="enterprise")
with pytest.raises(InvalidGrantError):
create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.VEN,
grant_reason="platform_default",
plan_id=None,
granted_by="platform",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
def test_platform_default_rejected_when_plan_id_present() -> None:
tenant = _tenant(grouping="trial")
with pytest.raises(InvalidGrantError):
create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.VEN,
grant_reason="platform_default",
plan_id="plan-x",
granted_by="platform",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
def test_manual_grant_allows_missing_plan_id_for_any_grouping() -> None:
tenant = _tenant(grouping="enterprise")
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.CUS,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
assert grant.grant_reason == "manual_grant"
def test_grant_revoke_is_append_only() -> None:
tenant = _tenant(grouping="friendly")
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.CUS,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
revoked = grant.revoke(at=datetime.now(UTC))
assert grant.revoked_at is None, "original record must be untouched"
assert revoked.revoked_at is not None
assert revoked.grant_id == grant.grant_id
def test_revoking_twice_raises() -> None:
tenant = _tenant(grouping="friendly")
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.CUS,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
).revoke(at=datetime.now(UTC))
with pytest.raises(InvalidGrantError):
grant.revoke(at=datetime.now(UTC))

124
tests/test_store.py Normal file
View file

@ -0,0 +1,124 @@
from datetime import UTC, datetime
import pytest
from tenant_engine.domain import CapabilityRole, PlanAssignment, Tenant, create_role_grant
from tenant_engine.store import (
GrantNotFoundError,
InMemoryTenantStore,
TenantAlreadyExistsError,
TenantNotFoundError,
)
def _store_with_tenant(*, grouping: str = "friendly", name: str = "binky") -> tuple[InMemoryTenantStore, Tenant]:
store = InMemoryTenantStore()
tenant = Tenant.create(tenant_id=f"t-{name}", identifier=f"tenant:{grouping}:{name}")
store.create_tenant(tenant)
return store, tenant
def test_create_and_get_tenant() -> None:
store, tenant = _store_with_tenant()
assert store.get_tenant(tenant.tenant_id) == tenant
def test_create_duplicate_tenant_raises() -> None:
store, tenant = _store_with_tenant()
with pytest.raises(TenantAlreadyExistsError):
store.create_tenant(tenant)
def test_get_unknown_tenant_raises() -> None:
store = InMemoryTenantStore()
with pytest.raises(TenantNotFoundError):
store.get_tenant("does-not-exist")
def test_grant_and_active_roles() -> None:
store, tenant = _store_with_tenant()
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.CUS,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
store.grant_role(grant)
assert store.active_roles(tenant.tenant_id) == frozenset({CapabilityRole.CUS})
def test_revoke_removes_role_from_active_set_but_keeps_record() -> None:
store, tenant = _store_with_tenant()
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.VEN,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
store.grant_role(grant)
revoked = store.revoke_role(tenant_id=tenant.tenant_id, grant_id="g-1", at=datetime.now(UTC))
assert revoked.revoked_at is not None
assert store.active_roles(tenant.tenant_id) == frozenset()
def test_revoke_unknown_grant_raises() -> None:
store, tenant = _store_with_tenant()
with pytest.raises(GrantNotFoundError):
store.revoke_role(tenant_id=tenant.tenant_id, grant_id="missing", at=datetime.now(UTC))
def test_non_exclusive_roles_coexist() -> None:
store, tenant = _store_with_tenant()
for role in (CapabilityRole.CUS, CapabilityRole.VEN):
store.grant_role(
create_role_grant(
tenant=tenant,
grant_id=f"g-{role.value}",
role=role,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
)
assert store.active_roles(tenant.tenant_id) == frozenset({CapabilityRole.CUS, CapabilityRole.VEN})
def test_assign_plan() -> None:
store, tenant = _store_with_tenant()
store.assign_plan(PlanAssignment(tenant_id=tenant.tenant_id, plan_id="plan-x", assigned_at=datetime.now(UTC)))
events = store.events()
assert any(event.event_type == "plan_assigned" and event.payload["plan_id"] == "plan-x" for event in events)
def test_every_mutation_emits_an_event() -> None:
store, tenant = _store_with_tenant()
grant = create_role_grant(
tenant=tenant,
grant_id="g-1",
role=CapabilityRole.CUS,
grant_reason="manual_grant",
plan_id=None,
granted_by="ops",
correlation_id="corr-1",
granted_at=datetime.now(UTC),
)
store.grant_role(grant)
store.revoke_role(tenant_id=tenant.tenant_id, grant_id="g-1", at=datetime.now(UTC))
store.assign_plan(PlanAssignment(tenant_id=tenant.tenant_id, plan_id="plan-x", assigned_at=datetime.now(UTC)))
event_types = [event.event_type for event in store.events()]
assert event_types == ["tenant_created", "role_granted", "role_revoked", "plan_assigned"]