Critical review of CUST-WP-0060 (T03-T06) found: shipped mechanism proven only by manual/live-repo runs, no repeatable test suite; tests/ never wired to CI at all (pre-existing gap, not introduced here). - tests/test_validate_work_records.py: 30 tests against the live canon registry/schemas — classify() incl. all grandfathered legacy id schemes, per-kind schema gates (intake open/closed/promoted, decision prepared/resolved, engagement prepared), multi-doc yaml handling, malformed-yaml-only-errors-if-id-registered, main() end-to-end via subprocess (exit codes, template placeholders, --strict escalation, terminal-record historical grace incl. the boundary case that grace must NOT mask real enum violations), and the jsonschema-unavailable fallback path (the exact failure mode that broke the first Forgejo CI run before the runner-substrate fix) - tools/validate_work_records.py: docstring said 'authoritative detector is fix-consistency C-25' — wrong, it landed as C-31 (C-25..C-30 were already taken); comment now correct - .forgejo/workflows/python-tests.yaml: wires tests/ to CI for the first time in this repo (apt python3/pytest/jsonschema/yaml on the node:20-bookworm substrate, same pattern as work-records.yaml) - tests/test_scan_workstream_terminology.py: found one pre-existing, unrelated failure while establishing the CI-representative baseline (agentic-resources allowlist entry no longer sets exclude_repo — a policy question, not a bug this task should resolve silently); marked xfail(strict=True) with the finding recorded so CI has a clean signal and a silent 'fix' doesn't go unnoticed either Local verification with apt-sourced deps (jsonschema 4.10.3, matching the CI runner's package source, not just pip): 34 passed, 1 known xfailed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
38 lines
1.3 KiB
YAML
38 lines
1.3 KiB
YAML
# Runs the repo's pytest suite (tests/) — previously unwired to CI, so
|
|
# regressions in tools/ (scan_workstream_terminology, validate_work_records,
|
|
# ...) went undetected. CUST-WP-0060 test-coverage follow-up.
|
|
# Runner substrate: ubuntu-latest maps to docker://node:20-bookworm (no
|
|
# python) — install python3 + deps via apt (same pattern as kaizen ci.yml
|
|
# and the work-records validation gate).
|
|
name: Python Tests
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
paths:
|
|
- "tools/**"
|
|
- "tests/**"
|
|
- "canon/standards/**"
|
|
- ".forgejo/workflows/python-tests.yaml"
|
|
pull_request:
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
pytest:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Fetch repo, run pytest
|
|
run: |
|
|
set -eu
|
|
apt-get update -qq >/dev/null
|
|
apt-get install -y -qq python3 python3-pip python3-yaml \
|
|
python3-jsonschema python3-pytest wget >/dev/null
|
|
WORK="$(mktemp -d)"; trap 'rm -rf "$WORK"' EXIT
|
|
REF="${GITHUB_SHA:-main}"; SHORT="${REF:0:7}"
|
|
wget -qO "$WORK/repo.tar.gz" \
|
|
"https://forgejo.coulomb.social/${GITHUB_REPOSITORY}/archive/${SHORT}.tar.gz"
|
|
mkdir -p "$WORK/repo"
|
|
tar xzf "$WORK/repo.tar.gz" -C "$WORK/repo" --strip-components=1
|
|
cd "$WORK/repo"
|
|
python3 -m pytest tests/ -q
|