USER-WP-0039: accept Authelia session ids with RFC 6265 cookie characters
All checks were successful
CI Smoke / host-smoke (push) Successful in 0s
CI Smoke / container-smoke (push) Successful in 1s
Build and Publish Container Image / build-and-push (push) Successful in 49s
Account journey acceptance / journeys (push) Successful in 47s

Real Authelia session ids contain '%', '^' and '!'. The narrower check
dropped them, so the Authelia uid always read 'not signed in / unknown'.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Assistant: claude-code
Assistant-Model: opus
Assistant-Process: 1041694@bnt-lap001
Assistant-Session: 7af0bb68-ac4a-4ce3-8639-24ddd84c0b52
This commit is contained in:
tegwick 2026-10-15 04:49:13 +02:00
parent 468d4c0822
commit 7f1db7189c
2 changed files with 11 additions and 1 deletions

View file

@ -17,7 +17,9 @@ from urllib.request import HTTPRedirectHandler, Request, build_opener
from user_engine.oidc import cookie_value
_IDENTITY_NAME = re.compile(r"^[A-Za-z0-9._@+-]{1,200}$")
_SESSION_TOKEN = re.compile(r"^[A-Za-z0-9._~+/=-]{1,4096}$")
# RFC 6265 cookie-octet: printable ASCII except space, '"', ',', ';' and '\'.
# Authelia session ids use characters such as '%', '^' and '!'.
_SESSION_TOKEN = re.compile(r"^[\x21\x23-\x2B\x2D-\x3A\x3C-\x5B\x5D-\x7E]{1,4096}$")
_PUBLIC_HOST = re.compile(r"[A-Za-z0-9](?:[A-Za-z0-9-]{0,61}[A-Za-z0-9])?(?:\.[A-Za-z0-9](?:[A-Za-z0-9-]{0,61}[A-Za-z0-9])?)+")
_CLUSTER_HOST = ".svc.cluster.local"

View file

@ -83,6 +83,14 @@ class IdentityStateParseTests(unittest.TestCase):
self.assertIsNone(authelia_session_token("authelia_session=" + ("a" * 4097)))
self.assertIsNone(authelia_session_token(""))
def test_cookie_token_accepts_authelia_session_id_characters(self):
# Synthetic value with the punctuation Authelia session ids contain.
value = "Ab3%Xy^Qr!st7Z8&*()[]{}<>?@`|:#$'"
self.assertEqual(value, authelia_session_token(f"authelia_session={value}; other=no"))
for bad in ('a b', 'a"b', "a\\b", "a\tb", "a\x7fb", "aéb"):
with self.subTest(bad=bad):
self.assertIsNone(authelia_session_token(f"authelia_session={bad}"))
def test_lookup_sends_only_the_session_token_and_fails_closed(self):
seen = []