AUDIT-WP-0004 T03, T05, T06. T03 - the receiver accepted whatever tenant and source a caller sent as long as it held the one shared token, despite WP-0003 recording tenant isolation as delivered. audit_core.senders binds each credential to the sources and tenants it may assert, driven by AUDIT_CORE_SENDERS rather than literals. Identities hold a list of tokens so rotation publishes the replacement alongside the incumbent and needs no delivery gap. Read is a separate privilege from write, so a sender credential cannot read the audit trail back. T05 - lookup by event id, lookup by correlation id, and a dead-letter view. Rejections are recorded rather than silently dropped. An event rejected for carrying secret-shaped material has its payload withheld: storing it would write that material into the audit store, which is what the rejection exists to prevent. Reason and payload hash are kept so it stays traceable. Replay is deliberately not built here. Idempotent replay is a property of the durable store and building it against SQLite would produce a second implementation to throw away; it lands with the Postgres backend in AUDIT-WP-0005-T01. T06 - serving moves to waitress with configurable threads and channel timeout, installed in the image via the serve extra. Without it the entrypoint falls back to a threaded wsgiref server with a socket timeout and graceful shutdown on SIGTERM, and logs a warning so a deployment cannot quietly land on the fallback. Metric counters deferred to WP-0005-T03 to be designed against the real scrape path. Tests 36 -> 46, covering cross-tenant and cross-source refusal, token rotation, read/write privilege separation, correlation lookup, and payload withholding on secret rejection. Remaining in WP-0004: T04 redaction policy, which needs a decision on whether a secret-shaped field is a rejection or a redaction. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
386 lines
15 KiB
Python
386 lines
15 KiB
Python
"""Authenticated, idempotent HTTP ingestion for user-engine outbox events.
|
|
|
|
Response contract (AUDIT-WP-0004-T02). Senders key their retry behaviour off
|
|
these, so they are part of the interface, not an implementation detail:
|
|
|
|
=== ========== =========================================================
|
|
202 accepted Event is durably in custody. Do not retry.
|
|
200 duplicate Exact resubmission of an event already in custody. Do not
|
|
retry; delivery already succeeded.
|
|
400 rejected Malformed or disallowed. Retrying will not help — dead
|
|
letter it.
|
|
401 unauthorized Credential missing or invalid. Do not retry without a
|
|
new credential.
|
|
409 conflict The event id is held with a different payload. Retrying
|
|
will not help; this indicates a sender bug or id reuse.
|
|
503 unavailable Not accepted, but retryable. Retry with backoff.
|
|
500 error Unexpected fault. Not accepted. Retryable with backoff.
|
|
=== ========== =========================================================
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import hashlib
|
|
import json
|
|
import logging
|
|
import os
|
|
import signal
|
|
import sys
|
|
from datetime import datetime, timezone
|
|
from http import HTTPStatus
|
|
from typing import Any
|
|
from urllib.parse import parse_qs
|
|
|
|
from audit_core.interface import (
|
|
AuditEvent,
|
|
BackendUnavailableError,
|
|
EventConflictError,
|
|
EventValidationError,
|
|
IdempotentAuditBackend,
|
|
)
|
|
from audit_core.senders import SenderIdentity, SenderRegistry, development_registry
|
|
from audit_core.sqlite_backend import SQLiteAuditBackend
|
|
|
|
MAX_BODY_BYTES = 256 * 1024
|
|
_SECRET_FRAGMENTS = ("password", "secret", "token", "credential", "private_key")
|
|
|
|
log = logging.getLogger("audit_core.ingestion")
|
|
|
|
|
|
class IngestionApplication:
|
|
"""WSGI application accepting user-engine outbox events.
|
|
|
|
Writes through the audit backend contract rather than to storage directly,
|
|
so a 202 means a backend with a declared retention policy acknowledged the
|
|
event.
|
|
"""
|
|
|
|
def __init__(
|
|
self, backend: IdempotentAuditBackend, senders: SenderRegistry | str
|
|
) -> None:
|
|
policy = backend.retention_policy
|
|
if not policy.durable:
|
|
# The mock file backend declares durable=False. Refusing it here is
|
|
# what stops a development sink from silently becoming the
|
|
# production one (AUDIT-WP-0004-T01).
|
|
raise ValueError(
|
|
f"backend custody_class={policy.custody_class!r} is not durable; "
|
|
"refusing to accept audit events against it"
|
|
)
|
|
if isinstance(senders, str):
|
|
if not senders:
|
|
raise ValueError("bearer token is required")
|
|
senders = development_registry(senders)
|
|
self.backend = backend
|
|
self.senders = senders
|
|
|
|
def __call__(self, environ, start_response):
|
|
try:
|
|
return self._handle(environ, start_response)
|
|
except Exception:
|
|
# Nothing may escape: an unhandled exception here means
|
|
# start_response is never called and the sender sees a dropped
|
|
# connection it cannot classify.
|
|
log.exception("unhandled error in ingestion request")
|
|
return self._json(
|
|
start_response, HTTPStatus.INTERNAL_SERVER_ERROR, {"error": "internal_error"}
|
|
)
|
|
|
|
def _handle(self, environ, start_response):
|
|
path = environ.get("PATH_INFO", "")
|
|
if path == "/healthz":
|
|
return self._json(start_response, HTTPStatus.OK, {"status": "ok"})
|
|
if path == "/readyz":
|
|
return self._readiness(start_response)
|
|
method = environ.get("REQUEST_METHOD")
|
|
identity = self.senders.authenticate(environ.get("HTTP_AUTHORIZATION"))
|
|
if identity is None:
|
|
return self._json(
|
|
start_response, HTTPStatus.UNAUTHORIZED, {"error": "unauthorized"}
|
|
)
|
|
|
|
if method == "GET" and (path.startswith("/v1/events") or path == "/v1/dead-letters"):
|
|
return self._read(start_response, environ, path, identity)
|
|
|
|
if path != "/v1/events" or method != "POST":
|
|
return self._json(start_response, HTTPStatus.NOT_FOUND, {"error": "not_found"})
|
|
|
|
if not identity.may_write:
|
|
return self._json(start_response, HTTPStatus.FORBIDDEN, {"error": "write_forbidden"})
|
|
|
|
raw = b""
|
|
try:
|
|
raw = self._read_body(environ)
|
|
event = normalize(
|
|
json.loads(raw), environ.get("HTTP_IDEMPOTENCY_KEY"), identity
|
|
)
|
|
except (ValueError, TypeError, KeyError, json.JSONDecodeError) as exc:
|
|
self._dead_letter(raw, str(exc), identity)
|
|
return self._json(start_response, HTTPStatus.BAD_REQUEST, {"error": str(exc)})
|
|
|
|
try:
|
|
result = self.backend.accept(event, hashlib.sha256(raw).hexdigest())
|
|
except EventConflictError as exc:
|
|
log.warning("event conflict: %s", exc)
|
|
return self._json(start_response, HTTPStatus.CONFLICT, {"error": "event_id_conflict"})
|
|
except EventValidationError as exc:
|
|
return self._json(start_response, HTTPStatus.BAD_REQUEST, {"error": str(exc)})
|
|
except BackendUnavailableError as exc:
|
|
log.error("backend unavailable: %s", exc)
|
|
return self._json(
|
|
start_response, HTTPStatus.SERVICE_UNAVAILABLE, {"error": "backend_unavailable"}
|
|
)
|
|
|
|
return self._json(
|
|
start_response,
|
|
HTTPStatus.OK if result.duplicate else HTTPStatus.ACCEPTED,
|
|
{
|
|
"status": "duplicate" if result.duplicate else "accepted",
|
|
"reference": result.reference,
|
|
},
|
|
)
|
|
|
|
def _read(self, start_response, environ, path: str, identity):
|
|
"""Operator read surface (AUDIT-WP-0004-T05).
|
|
|
|
Read is a distinct privilege from write: a sender credential must not
|
|
be able to read the audit trail back.
|
|
"""
|
|
if not identity.may_read:
|
|
return self._json(start_response, HTTPStatus.FORBIDDEN, {"error": "read_forbidden"})
|
|
|
|
query = parse_qs(environ.get("QUERY_STRING", ""))
|
|
try:
|
|
if path == "/v1/dead-letters":
|
|
return self._json(
|
|
start_response, HTTPStatus.OK,
|
|
{"dead_letters": self.backend.dead_letters(_limit(query))},
|
|
)
|
|
if path == "/v1/events":
|
|
correlation = (query.get("correlation_id") or [""])[0]
|
|
if not correlation:
|
|
return self._json(
|
|
start_response, HTTPStatus.BAD_REQUEST,
|
|
{"error": "correlation_id_required"},
|
|
)
|
|
return self._json(
|
|
start_response, HTTPStatus.OK,
|
|
{"events": self.backend.by_correlation(correlation, _limit(query))},
|
|
)
|
|
event_id = path[len("/v1/events/"):]
|
|
record = self.backend.get(event_id) if event_id else None
|
|
if record is None:
|
|
return self._json(start_response, HTTPStatus.NOT_FOUND, {"error": "not_found"})
|
|
return self._json(start_response, HTTPStatus.OK, record)
|
|
except BackendUnavailableError as exc:
|
|
log.error("read failed: %s", exc)
|
|
return self._json(
|
|
start_response, HTTPStatus.SERVICE_UNAVAILABLE, {"error": "backend_unavailable"}
|
|
)
|
|
|
|
def _dead_letter(self, raw: bytes, reason: str, identity) -> None:
|
|
"""Record a rejection so an operator can see what the sender dropped."""
|
|
recorder = getattr(self.backend, "record_rejection", None)
|
|
if not callable(recorder):
|
|
return
|
|
event_id = None
|
|
try:
|
|
parsed = json.loads(raw)
|
|
if isinstance(parsed, dict):
|
|
event_id = str(parsed.get("id") or "") or None
|
|
except (ValueError, TypeError):
|
|
pass
|
|
try:
|
|
recorder(
|
|
event_id=event_id,
|
|
reason=reason,
|
|
payload_hash=hashlib.sha256(raw).hexdigest(),
|
|
sender=identity.name,
|
|
payload=raw.decode("utf-8", "replace"),
|
|
)
|
|
except BackendUnavailableError as exc:
|
|
# A rejection we could not record is worth a log line, but it must
|
|
# not turn a 400 into a 503 — the event is still rejected.
|
|
log.error("could not record dead letter: %s", exc)
|
|
|
|
def _read_body(self, environ) -> bytes:
|
|
try:
|
|
length = int(environ.get("CONTENT_LENGTH") or 0)
|
|
except (TypeError, ValueError):
|
|
raise ValueError("invalid_content_length") from None
|
|
if length <= 0:
|
|
raise ValueError("empty_body")
|
|
if length > MAX_BODY_BYTES:
|
|
raise ValueError("payload_too_large")
|
|
raw = environ["wsgi.input"].read(length)
|
|
if len(raw) != length:
|
|
raise ValueError("truncated_body")
|
|
return raw
|
|
|
|
def _readiness(self, start_response):
|
|
try:
|
|
health = getattr(self.backend, "health", None)
|
|
if callable(health):
|
|
health()
|
|
except BackendUnavailableError as exc:
|
|
log.error("readiness failed: %s", exc)
|
|
return self._json(
|
|
start_response, HTTPStatus.SERVICE_UNAVAILABLE, {"status": "unavailable"}
|
|
)
|
|
policy = self.backend.retention_policy
|
|
return self._json(
|
|
start_response,
|
|
HTTPStatus.OK,
|
|
{"status": "ok", "custody_class": policy.custody_class, "durable": policy.durable},
|
|
)
|
|
|
|
@staticmethod
|
|
def _json(start_response, status: HTTPStatus, payload: dict[str, Any]):
|
|
body = json.dumps(payload).encode()
|
|
start_response(
|
|
f"{status.value} {status.phrase}",
|
|
[("Content-Type", "application/json"), ("Content-Length", str(len(body)))],
|
|
)
|
|
return [body]
|
|
|
|
|
|
def normalize(
|
|
payload: dict[str, Any],
|
|
idempotency_key: str | None,
|
|
identity: SenderIdentity | None = None,
|
|
) -> AuditEvent:
|
|
required = (
|
|
"id", "type", "source", "subject", "tenant", "correlation_id", "occurred_at", "data",
|
|
)
|
|
if not isinstance(payload, dict) or any(not payload.get(key) for key in required):
|
|
raise ValueError("invalid_event")
|
|
if idempotency_key != payload["id"]:
|
|
raise ValueError("idempotency_key_mismatch")
|
|
source = str(payload["source"])
|
|
tenant = str(payload["tenant"])
|
|
# The claimed source and tenant are checked against what this credential is
|
|
# permitted to assert, not against a literal (AUDIT-WP-0004-T03).
|
|
if identity is not None:
|
|
if not identity.permits_source(source):
|
|
raise ValueError("source_not_allowed")
|
|
if not identity.permits_tenant(tenant):
|
|
raise ValueError("tenant_not_allowed")
|
|
elif source != "user-engine":
|
|
raise ValueError("source_not_allowed")
|
|
observed_at = _normalize_timestamp(payload["occurred_at"])
|
|
if _contains_secret(payload["data"]):
|
|
raise ValueError("secret_shaped_field")
|
|
return AuditEvent(
|
|
event_id=str(payload["id"]),
|
|
observed_at=observed_at,
|
|
tenant=tenant,
|
|
scope="tenant",
|
|
source=source,
|
|
action=str(payload["type"]),
|
|
resource=str(payload["subject"]),
|
|
outcome="recorded",
|
|
actor=None,
|
|
details={"correlation_id": str(payload["correlation_id"]), "data": payload["data"]},
|
|
)
|
|
|
|
|
|
def _normalize_timestamp(value: Any) -> str:
|
|
"""Parse an event timestamp, requiring an explicit offset.
|
|
|
|
A naive timestamp is ambiguous by up to a day, which is not good enough for
|
|
an audit trail — the sender must say which offset it meant.
|
|
"""
|
|
try:
|
|
parsed = datetime.fromisoformat(str(value).replace("Z", "+00:00"))
|
|
except (TypeError, ValueError):
|
|
raise ValueError("invalid_timestamp") from None
|
|
if parsed.tzinfo is None:
|
|
raise ValueError("timestamp_missing_timezone")
|
|
return parsed.astimezone(timezone.utc).isoformat()
|
|
|
|
|
|
def _contains_secret(value: Any) -> bool:
|
|
if isinstance(value, dict):
|
|
return any(
|
|
any(fragment in str(key).lower() for fragment in _SECRET_FRAGMENTS)
|
|
or _contains_secret(item)
|
|
for key, item in value.items()
|
|
)
|
|
if isinstance(value, list):
|
|
return any(_contains_secret(item) for item in value)
|
|
return False
|
|
|
|
|
|
def _limit(query: dict[str, list[str]], default: int = 100, ceiling: int = 1000) -> int:
|
|
try:
|
|
return max(1, min(int((query.get("limit") or [default])[0]), ceiling))
|
|
except (TypeError, ValueError):
|
|
return default
|
|
|
|
|
|
def serve(app, host: str, port: int, threads: int, timeout: int) -> None:
|
|
"""Serve ``app``, preferring a production WSGI server (T06).
|
|
|
|
waitress is the intended production server and is installed in the image
|
|
via the ``serve`` extra. The fallback is a threaded wsgiref server with a
|
|
socket timeout — bounded rather than good, and loud about which one is in
|
|
use so a deployment cannot quietly end up on the fallback.
|
|
"""
|
|
try:
|
|
from waitress import serve as waitress_serve
|
|
except ImportError:
|
|
log.warning(
|
|
"waitress not installed — falling back to a threaded wsgiref server. "
|
|
"Install the 'serve' extra for production (AUDIT-WP-0004-T06)."
|
|
)
|
|
_serve_fallback(app, host, port, timeout)
|
|
return
|
|
|
|
log.info("serving on waitress host=%s port=%s threads=%s", host, port, threads)
|
|
waitress_serve(
|
|
app, host=host, port=port, threads=threads,
|
|
channel_timeout=timeout, ident="audit-core",
|
|
)
|
|
|
|
|
|
def _serve_fallback(app, host: str, port: int, timeout: int) -> None:
|
|
from socketserver import ThreadingMixIn
|
|
from wsgiref.simple_server import WSGIServer, make_server
|
|
|
|
class ThreadedWSGIServer(ThreadingMixIn, WSGIServer):
|
|
daemon_threads = True
|
|
# Without this a slow or idle client holds a worker indefinitely; the
|
|
# original single-threaded server let one such client block every
|
|
# sender.
|
|
timeout = timeout
|
|
|
|
with make_server(host, port, app, server_class=ThreadedWSGIServer) as server:
|
|
server.socket.settimeout(timeout)
|
|
|
|
def shutdown(signum, _frame):
|
|
log.info("received signal %s, shutting down", signum)
|
|
server.shutdown()
|
|
|
|
for sig in (signal.SIGTERM, signal.SIGINT):
|
|
signal.signal(sig, shutdown)
|
|
log.info("serving on threaded wsgiref host=%s port=%s", host, port)
|
|
server.serve_forever()
|
|
|
|
|
|
def main() -> None:
|
|
logging.basicConfig(
|
|
level=os.environ.get("AUDIT_CORE_LOG_LEVEL", "INFO"),
|
|
format='{"ts":"%(asctime)s","level":"%(levelname)s","logger":"%(name)s","msg":"%(message)s"}',
|
|
stream=sys.stdout,
|
|
)
|
|
backend = SQLiteAuditBackend(
|
|
os.environ.get("AUDIT_CORE_DATABASE_PATH", "/data/audit-core.db")
|
|
)
|
|
app = IngestionApplication(backend, SenderRegistry.from_env())
|
|
serve(
|
|
app,
|
|
host=os.environ.get("AUDIT_CORE_HOST", "0.0.0.0"),
|
|
port=int(os.environ.get("AUDIT_CORE_HTTP_PORT", "8080")),
|
|
threads=int(os.environ.get("AUDIT_CORE_THREADS", "8")),
|
|
timeout=int(os.environ.get("AUDIT_CORE_REQUEST_TIMEOUT", "30")),
|
|
)
|