tegwick
5867842b94
All checks were successful
ci / validate (push) Successful in 47s
Assistant: codex Assistant-Model: gpt-6-astra Assistant-Session: 01a0726e-5232-73f2-aaca-2c05ceb62efb
70 lines
2.5 KiB
Markdown
70 lines
2.5 KiB
Markdown
---
|
|
id: GLAS-WP-ADHOC-2026-09-06
|
|
type: workplan
|
|
title: "Repository review: session isolation and startup failure reporting"
|
|
domain: infotech
|
|
repo: glas-harness
|
|
status: finished
|
|
owner: codex
|
|
topic_slug: repository-review
|
|
created: "2026-09-06"
|
|
updated: "2026-09-06"
|
|
state_hub_workstream_id: "33761e0d-f9eb-5f0a-919e-180ca0ae0173"
|
|
---
|
|
|
|
# Repository review
|
|
|
|
The working tree was clean at review start. GLAS-WP-0012 is the only unfinished
|
|
workplan. Its real-key proof still waits on owner activation and runtime
|
|
acceptance; the latest owner update is recorded there. These bounded local
|
|
fixes do not change profile readiness. No residuals from these fixes.
|
|
|
|
## Isolate reusable rein session results
|
|
|
|
```task
|
|
id: ADHOC-2026-09-06-T01
|
|
status: done
|
|
priority: medium
|
|
state_hub_task_id: "1c37cc76-2ac1-5e86-9d05-77dfb8a8efac"
|
|
```
|
|
|
|
Both adapters stored the parsed CLI response on the adapter instance. When two
|
|
sessions interleaved, ending the first used the second session's outcome,
|
|
model and usage. Store the response in its session and read it from there.
|
|
The regression test reproduces the mixed outcome in both adapters before the
|
|
fix and validates distinct outcomes/model/usage afterwards.
|
|
|
|
## Normalize sandbox manager initialization failure
|
|
|
|
```task
|
|
id: ADHOC-2026-09-06-T02
|
|
status: done
|
|
priority: medium
|
|
state_hub_task_id: "2de34643-952c-5eb0-9c54-3ecb42ba8d9a"
|
|
```
|
|
|
|
Move default manager construction inside the sandbox-create error boundary.
|
|
Initialization failure now returns a failed GatewayResult with sandbox_create
|
|
stage and no sandbox id. Direct callers retain the error; Hub evidence omits
|
|
its raw contents. The regression test failed with an escaping exception before
|
|
the fix and passes afterwards.
|
|
|
|
Validation: full suite 104 passed; profile catalog validation passed with
|
|
existing readiness unchanged. Reviewed credential owner update and refreshed
|
|
the proposed policy reference in docs/anthropic-workload-key.md.
|
|
|
|
## Reject ambiguous catalog YAML
|
|
|
|
```task
|
|
id: ADHOC-2026-09-06-T03
|
|
status: done
|
|
priority: medium
|
|
state_hub_task_id: "14e0f94c-28e9-55a4-82a4-d3bb739f4489"
|
|
```
|
|
|
|
Follow-up repository review found that YAML silently overwrote duplicate keys
|
|
before profile validation. Both profile and rein descriptor loading now reject
|
|
duplicate keys at every mapping depth, including merge collisions. Disjoint
|
|
merges remain supported. Four regression cases reproduced silent acceptance
|
|
before the change. Full suite: 110 passed; committed catalog validation passes.
|
|
No residuals from this bounded fix; GLAS-WP-0012 retains the live-proof work.
|